Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landesfeind electrolyte parameters #1048

Closed
brosaplanella opened this issue Jun 10, 2020 · 0 comments · Fixed by #1064
Closed

Landesfeind electrolyte parameters #1048

brosaplanella opened this issue Jun 10, 2020 · 0 comments · Fixed by #1064

Comments

@brosaplanella
Copy link
Sponsor Member

At the moment the Landesfeind electrolyte parameter set cannot be directly called as the diffusivities and conductivities for three different types of electrolyte are in the same folder and they don't have a parameters.csv file associated.

I suggest splitting it into three different parameter sets: lipf6_EC-DMC_1-1_Landesfeind2019, lipf6_EC-EMC_3-7_Landesfeind2019 and lipf6_EMC-FEC_19-1_Landesfeind2019. We can incorporate thermodynamic factors and transfer numbers as well.

Please comment if you have any suggestions.
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 14, 2020
@brosaplanella
pybamm-team#1048 set tests
0118999
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 14, 2020
@brosaplanella
pybamm-team#1048 added base Landesfeind functions
ca5fad4
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 14, 2020
@brosaplanella
pybamm-team#1048 added EC:DMC 1:1 but still not working
e0fe386
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 set tests
b078d8f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 added base Landesfeind functions
3ddef54
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 added EC:DMC 1:1 but still not working
0c16119
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 remove base electrolyte folder and old test
7ecc65b
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 added Landesfeind parameters test
c4fc572
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 fixed EC-DMC electrolyte
16ef250
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 added EC-EMC electrolyte
4adee94
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 added EMC-FEC electrolyte
9cdf761
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 flake8
c9d2082
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 19, 2020
@brosaplanella
pybamm-team#1048 remove old Landesfeind parameter set
74122fb
@brosaplanella brosaplanella mentioned this issue Jun 19, 2020
Merged
8 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 20, 2020
@brosaplanella
pybamm-team#1048 CHANGELOG
199d852
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 fixed typos
fef513d
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 set tests
36d6ea2
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 added base Landesfeind functions
fa330a2
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 added EC:DMC 1:1 but still not working
05664d5
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 remove base electrolyte folder and old test
e3f4b33
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 added Landesfeind parameters test
5c3ebb5
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 fixed EC-DMC electrolyte
741bd49
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 added EC-EMC electrolyte
dc049dc
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 added EMC-FEC electrolyte
12cb5cc
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 flake8
8ff853c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 remove old Landesfeind parameter set
3ddefde
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 CHANGELOG
84fc9ed
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 fixed typos
3a03134
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 22, 2020
@brosaplanella
pybamm-team#1048 fixed more typos
b2a9121
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 set tests
1bd8dfc
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added base Landesfeind functions
5a4c310
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EC:DMC 1:1 but still not working
9bd04e4
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 remove base electrolyte folder and old test
320ceac
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added Landesfeind parameters test
67d6f2e
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 fixed EC-DMC electrolyte
5be6e1c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EC-EMC electrolyte
5526e1c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EMC-FEC electrolyte
8a0cece
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 flake8
1cd1703
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 remove old Landesfeind parameter set
8ca2c67
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 CHANGELOG
a43d708
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 fixed typos
db2f502
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added base Landesfeind functions
583fd6f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EC:DMC 1:1 but still not working
984397d
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 remove base electrolyte folder and old test
aae0a7b
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 fixed EC-DMC electrolyte
24ed701
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EC-EMC electrolyte
449b515
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 added EMC-FEC electrolyte
cc10301
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 fixed typos
6e527e2
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 23, 2020
@brosaplanella
pybamm-team#1048 fixed more typos
e278dca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1048 reformat landesfeind electrolyte brosaplanella/PyBaMM
1 participant
@brosaplanella