-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1048 reformat landesfeind electrolyte #1064
Merged
valentinsulzer
merged 77 commits into
pybamm-team:develop
from
brosaplanella:issue-1048-reformat-landesfeind-electrolyte
Jun 23, 2020
Merged
Issue 1048 reformat landesfeind electrolyte #1064
valentinsulzer
merged 77 commits into
pybamm-team:develop
from
brosaplanella:issue-1048-reformat-landesfeind-electrolyte
Jun 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osa/PyBaMM into issue-1044-google-colab
…/github.com/ferranbrosa/PyBaMM into issue-1048-reformat-landesfeind-electrolyte
…ional-casadi-funcitons pybamm-team#1066 add numpy function sqrt, sin, cos and exp to convert_to_casadi
@ferranbrosa can you merge develop into your branch, this should fix the tests |
…/github.com/ferranbrosa/PyBaMM into issue-1048-reformat-landesfeind-electrolyte
All fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reformatted the Landesfeind electrolyte parameters so now they can be called directly by setting
"electrolyte": "lipf6_EC_EMC_3_7_Landesfeind2019"
(or similar).Fixes #1048
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: