Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1048 reformat landesfeind electrolyte #1064

Conversation

brosaplanella
Copy link
Sponsor Member

Description

Reformatted the Landesfeind electrolyte parameters so now they can be called directly by setting "electrolyte": "lipf6_EC_EMC_3_7_Landesfeind2019" (or similar).

Fixes #1048

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer
Copy link
Member

@ferranbrosa can you merge develop into your branch, this should fix the tests

@brosaplanella
Copy link
Sponsor Member Author

All fixed now!

@valentinsulzer valentinsulzer merged commit 903ab78 into pybamm-team:develop Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landesfeind electrolyte parameters
3 participants