Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature dependent electrode conductivity #1570

Conversation

brosaplanella
Copy link
Sponsor Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1506

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1570 (208294b) into develop (7d413ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1570   +/-   ##
========================================
  Coverage    97.78%   97.78%           
========================================
  Files          323      323           
  Lines        17523    17552   +29     
========================================
+ Hits         17135    17164   +29     
  Misses         388      388           
Impacted Files Coverage Δ
...ction/through_cell/base_through_cell_convection.py 100.00% <ø> (ø)
...ubmodels/external_circuit/base_external_circuit.py 100.00% <ø> (ø)
...ternal_circuit/current_control_external_circuit.py 100.00% <ø> (ø)
...ernal_circuit/function_control_external_circuit.py 98.07% <ø> (ø)
...dels/submodels/interface/kinetics/butler_volmer.py 100.00% <ø> (ø)
...ybamm/models/submodels/interface/kinetics/tafel.py 100.00% <ø> (ø)
...amm/models/submodels/particle_cracking/__init__.py 100.00% <ø> (ø)
pybamm/models/submodels/thermal/base_thermal.py 100.00% <ø> (ø)
...models/full_battery_models/lead_acid/basic_full.py 100.00% <100.00%> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d413ed...208294b. Read the comment docs.

@valentinsulzer valentinsulzer merged commit ef4f516 into pybamm-team:develop Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrical conductivity as function of temperature
2 participants