Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend positions deadline #191

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Extend positions deadline #191

merged 4 commits into from
Sep 6, 2024

Conversation

brosaplanella
Copy link
Sponsor Member

Positions deadline extended until 27th of September.

@brosaplanella brosaplanella marked this pull request as ready for review September 5, 2024 22:28
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for pybamm-developer-preview ready!

Name Link
🔨 Latest commit 2a142f5
🔍 Latest deploy log https://app.netlify.com/sites/pybamm-developer-preview/deploys/66db042af814420008dcb220
😎 Deploy Preview https://deploy-preview-191--pybamm-developer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brosaplanella
Copy link
Sponsor Member Author

Note: some of the failing links have been addressed in #190 (so not here).

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brosaplanella! Could you please update this over at the NumFOCUS jobs board, too? Also, we could link to this page from the newly-added Jobs page, perhaps.

@brosaplanella
Copy link
Sponsor Member Author

Opened the PR at the NumFOCUS job board: numfocus/jobs-board#49

@brosaplanella
Copy link
Sponsor Member Author

Also posted to the job board, if you are happy with the changes, feel free to merge :)

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjxn-py
Copy link
Member

arjxn-py commented Sep 6, 2024

@agriyakhetarpal link checker is failing for quite sometime. I shall try to fix it in a PR over this coming weekend, if that sounds alright.

@arjxn-py
Copy link
Member

arjxn-py commented Sep 6, 2024

Sorry for suggesting this now if we're in a hurry. But according to me it also makes much sense to have a similar note as in 48811c1 at Get Involved page. It's totally fine if that doesn't makes sense. Feel free to merge in that case. Thanks :)

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Sep 6, 2024

@agriyakhetarpal link checker is failing for quite sometime. I shall try to fix it in a PR over this coming weekend, if that sounds alright.

Yes, thanks for being up for fixing the link, @arjxn-py! It's coming from the all-contributors specification from the PyBaMM repository, so the automatic update will bring the failing links back if we fix it here instead of there. We could ignore the Teams page here, though, that would be easier (since we do it for the PyBaMM repo, too).

Sorry for suggesting this now if we're in a hurry. But according to me it also makes much sense to have a similar note as in 48811c1 at Get Involved page. It's totally fine if that doesn't makes sense. Feel free to merge in that case. Thanks :)

Yes, I think that is a good idea – we could add it to the Get Involved page as a section at the end of it? We can go ahead with it if @brosaplanella thinks this is an appropriate place (or we could move this higher up).

@brosaplanella
Copy link
Sponsor Member Author

Yes, please, if you can push that it would be great (I won't have time to do it for the next few hours).

@agriyakhetarpal agriyakhetarpal merged commit d8736e1 into main Sep 6, 2024
5 of 6 checks passed
@agriyakhetarpal agriyakhetarpal deleted the extend-position-deadline branch September 6, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants