Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scheduled test failing on PyBaMM 23.5 #251

Closed
BradyPlanden opened this issue Mar 21, 2024 · 0 comments · Fixed by #252
Closed

[Bug]: Scheduled test failing on PyBaMM 23.5 #251

BradyPlanden opened this issue Mar 21, 2024 · 0 comments · Fixed by #252
Assignees
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

N/A

Describe the bug

Scheduled tests are failing on PyBaMM v23.5 as the Thevenin solution object did not obtain standard variables such as "Time [s]" until the following release. For more information see pybamm-team/PyBaMM#3129.

To fix this, we have a few options:

  1. Add a catch for this error that we depreciate after we drop support for v23.5
  2. Modify the PyBOP Thevenin class to not depend on the "Time [s]" for PyBaMM v23.5
  3. Increment the PyBaMM dependency to no longer support v23.5

I'm in favour of 1 or 3. Since we control and package PyBaMM versioning within PyBOP there shouldn't be an issue with incrementing this dependency.

Steps to reproduce the behaviour

nox -s quick with PyBaMM v23.5

Relevant log output

https://github.com/pybop-team/PyBOP/actions/runs/8376046378
@BradyPlanden BradyPlanden added the bug Something isn't working label Mar 21, 2024
@BradyPlanden BradyPlanden self-assigned this Mar 22, 2024
@BradyPlanden BradyPlanden linked a pull request Mar 22, 2024 that will close this issue
14 tasks
@BradyPlanden BradyPlanden mentioned this issue Mar 25, 2024
5 tasks
BradyPlanden added a commit that referenced this issue Apr 8, 2024
…integration tests in parameterisation tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant