Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make v24.3 #220

Merged
merged 430 commits into from
Mar 25, 2024
Merged

Make v24.3 #220

merged 430 commits into from
Mar 25, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Feb 26, 2024 •
edited
Loading

PR for v24.3. Merge into main once the following has been added:

@NicolaCourtier @martinjrobins @agriyakhetarpal feel free to add to the above list, or comment if you think we should release without one of them. Alternatively, we this could be v24.3rc1 and we can iterate release candidates as the above gets completed (probably with a cut-off though). Closes #201.

pre-commit-ci bot and others added 30 commits February 8, 2024 16:40
@pre-commit-ci
style: pre-commit fixes
2920865
@NicolaCourtier
Update UKF example plotting
1cdea9e
@NicolaCourtier
Update simulate
44e935c
@BradyPlanden
Add BaseModel tests
d3fa97f
@BradyPlanden
Merge pull request #167 from pybop-team/162-update-design-optimisatio…
27c49f0 
…n-functionality

Design Optimisation Refactor and Additions
@BradyPlanden
Add M1 GitHub runners, Updt. self-hosted
3fa1249
@BradyPlanden
Updt changelog
1253360
@BradyPlanden
Remove M1 tests on unsupported python versions
3cf96ae
@NicolaCourtier
Add VolumetricEnergyDensity example (#191)
7d09c5d 
* Add VolumetricEnergyDensity example

* Update CHANGELOG.md

* Update test_cost.py

* Update example to pass coverage tests

* Split cost classes by type

* Add DesignCost to init

* Update error checking
@NicolaCourtier
Revert file names
a189796
@NicolaCourtier
Merge branch 'develop' into 177-plotting-capabilities
3f66b25
@NicolaCourtier
Re-implement change to BaseCost
ac10023
@NicolaCourtier
Separate off plot_parameters
93095b6
@pre-commit-ci
style: pre-commit fixes
bfe5bb9
@NicolaCourtier
Move plot_parameters in init
1ccfda1
@NicolaCourtier
Update spm_electrode_design.ipynb
993aa91
@NicolaCourtier
Re-implement design changes to quick_plot
541ac05
@agriyakhetarpal
#123 rename: release-action to release_action
695170f
@agriyakhetarpal
#123 add custom script to dynamically generate matrix
bff90d6
@agriyakhetarpal
#123 run script, pass generated matrix to next job
4f64bd4
@agriyakhetarpal
#123 make script executable prior to running it
48a3e12
@agriyakhetarpal
#123 don't allow running M-series builds on forks
c324365
@agriyakhetarpal
#123 don't use git update-index for file permissions
e56eb36
@agriyakhetarpal
#123 move script to a dedicated scripts/ci/ folder
8c06d23
@agriyakhetarpal
#123 correctly sparse checkout the matrix script
bfe8474
@agriyakhetarpal
#123 fix up script to return valid JSON
77e233d
@agriyakhetarpal
#123 simplify GitHub Actions output processing
d26a48f
@agriyakhetarpal
#123 convert JSON to string before parsing
a4e0979
@agriyakhetarpal
#123 move output before all jobs and test
4679821
@agriyakhetarpal
#123 don't convert JSON output to raw strings
d09b537
NicolaCourtier and others added 25 commits March 20, 2024 12:47
@NicolaCourtier
Add test_with_ipykernel
47c0058
@pre-commit-ci
style: pre-commit fixes
1a80b6f
@NicolaCourtier
Re-add test_with_ipykernel
fa551a0
@NicolaCourtier
Update test_plots.py
b6ce663
@NicolaCourtier
Rename plot_cost2d as plot2d
f198cbe
@NicolaCourtier
Merge plot_optim2d with plot2d
9ef3897
@NicolaCourtier
Update scripts to plot2d
f42298f
@NicolaCourtier
Update notebooks to plot2d
3ca404d
@NicolaCourtier
Update spm_MLE.py
302add7
@NicolaCourtier
Update filename to plot2d
fe090f1
@NicolaCourtier
Rename plot_cost2d.py to plot2d.py
7b8c7f0
@NicolaCourtier
Fix typo in error message
8bfaeba
@NicolaCourtier
Reduce init_soc in test_model_misparameterisation
cb70505
@NicolaCourtier @BradyPlanden
Update ipykernel print to assert
76b5c19 
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
@NicolaCourtier
Fix version check
e513c33
@NicolaCourtier
Merge pull request #178 from pybop-team/177-plotting-capabilities
b2afea4 
Update plotting capabilities and dataset restructure
@BradyPlanden
Merge branch 'develop' into v24.2
91724ab
@BradyPlanden
Merge branch 'develop' into 244-add-reorder-python-imports-to-pre-commit
899b117
@pre-commit-ci
style: pre-commit fixes
80514d0
@BradyPlanden
Merge pull request #245 from pybop-team/244-add-reorder-python-import…
75967f7 
…s-to-pre-commit

Adds import linting with ruff
@BradyPlanden
Updt model.simulateS1, refactor cost evaluates for object change + si…
a02634d 
…mplify, updt. tests
@BradyPlanden
updt changelog
63b3792
@BradyPlanden
move changelog entry to bugfix
47767c7
@BradyPlanden
Merge pull request #260 from pybop-team/259-bug-incorrect-gradient-ob…
21119db 
…ject-from-basemodels1

Fix gradient calculation from `model.simulateS1`
@BradyPlanden
Merge branch 'develop' into v24.2
45785ab
@BradyPlanden
Copy link
Member Author

Merging this as scheduled tests are passing for pybamm > 23.5 . This will be incremented for future releases as discussed in #251.

@BradyPlanden BradyPlanden merged commit 92abe7e into main Mar 25, 2024
37 of 83 checks passed
@BradyPlanden BradyPlanden deleted the v24.2 branch May 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolaCourtier NicolaCourtier Awaiting requested review from NicolaCourtier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BradyPlanden @NicolaCourtier @agriyakhetarpal @martinjrobins