Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMC marginal test failing due to input type #5324

Closed
ricardoV94 opened this issue Jan 8, 2022 · 1 comment
Closed

SMC marginal test failing due to input type #5324

ricardoV94 opened this issue Jan 8, 2022 · 1 comment
Labels
SMC Sequential Monte Carlo tests

Comments

@ricardoV94
Copy link
Member

This SMC test is failing in main https://github.com/pymc-devs/pymc/runs/4740953565?check_suite_focus=true#step:7:746

This is somewhat related to #5263, we wouldn't need those nan otherwise.
@ricardoV94 ricardoV94 added SMC Sequential Monte Carlo tests labels Jan 8, 2022
@ricardoV94 ricardoV94 mentioned this issue Jan 9, 2022
Merged
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix pymc-devs#5324
b4b4620
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix pymc-devs#5324
384ef6a
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix pymc-devs#5324
96bc0dc
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix brittle check in test_marginal_likelihood
42e3eaa 
Closes pymc-devs#5324
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix brittle check in test_marginal_likelihood
e2a6751 
Closes pymc-devs#5324
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix brittle check in test_marginal_likelihood
c044f34 
This would fail when the chains do not have the same length, resulting in the marginal_likelihood being wrapped in a numpy array of `object` dtype. This led the nanmean call to fail with an AttributeError

Closes pymc-devs#5324
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jan 13, 2022
@ricardoV94
Fix brittle check in test_marginal_likelihood
cd1b313 
This would fail when the chains do not have the same length, resulting in the marginal_likelihood being wrapped in a numpy array of `object` dtype. This led the nanmean call to fail with an AttributeError

Closes pymc-devs#5324
@ricardoV94
Copy link
Member Author

Should be solved now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SMC Sequential Monte Carlo tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94