Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aeppl logp reference #5327

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Add aeppl logp reference #5327

merged 1 commit into from
Jan 9, 2022

Conversation

canyon289
Copy link
Member

Add aeppl logp reference per discussion here

#5298 (comment)

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #5327 (54a5e65) into main (664a447) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5327   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          89       89           
  Lines       14863    14863           
=======================================
  Hits        11918    11918           
  Misses       2945     2945           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.43% <ø> (ø)

@ricardoV94
Copy link
Member

There are several other like this. Any distribution that appears in that aeppl file and has no logp in PyMC

@twiecki twiecki self-requested a review January 9, 2022 11:40
@canyon289
Copy link
Member Author

There are several other like this. Any distribution that appears in that aeppl file and has no logp in PyMC

I know, but heres my bigger plan. I'm purposely creating many small examples that can be used for the data umbrella sprint. So this for instance is a fairly easy contribution for a newcomer to make, especially now that there's a single example.

This issue I created is another example of one thats suitable for a sprint. You very likely are going to see me merge other PRs like this in prep for the sprint.
#5326

If these are not completed for the sprint they still are good beginner examples to build community engagement in the codebase

Assuming the CI failure is a flaky one and merging

@ricardoV94
Copy link
Member

oops deleted branch by accident. Issue looks like #5324, we need to fix that or it will keep failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants