Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool recommendations #1474

Merged
merged 19 commits into from
Feb 29, 2024
Merged

Update tool recommendations #1474

merged 19 commits into from
Feb 29, 2024

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Dec 30, 2023

This is my proposal to address #1468.

Fixes #1468


📚 Documentation preview 📚: https://python-packaging-user-guide--1474.org.readthedocs.build/en/1474/guides/tool-recommendations/

source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
@jeanas
Copy link
Contributor Author

jeanas commented Dec 30, 2023

@chrysle Thanks for reviewing! I've addressed your comments, sometimes with slightly different wordings.

source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
source/guides/tool-recommendations.rst Outdated Show resolved Hide resolved
@jeanas
Copy link
Contributor Author

jeanas commented Jan 16, 2024

I believe I've addressed all review comments. There were many reviews and it's not clear to me whether reviewers are now OK with the PR or just didn't have the time to take another look.

@webknjaz
Copy link
Member

I didn't have time, but I hope to find some.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked all the threads as resolved as there doesn't seem to be anything more actionable or blocking.

@webknjaz
Copy link
Member

The CI seems to be failing for an unrelated reason:

(tutorials/installing-packages: line  444) broken    https://stackoverflow.com/a/14638025 - 403 Client Error: Forbidden for url: https://stackoverflow.com/a/14638025

The deps don't seem to differ compared to main so it's probably SO that's blocking HTTP requests from GH somehow. Will need to figure it out first.

@willingc
Copy link
Contributor

@webknjaz Maybe for CI, we change the SO link in the source to: https://stackoverflow.com/questions/14637979/how-to-permanently-set-path-on-linux-unix/14638025#14638025 It's where the CI link actually redirects if entered in the browser.

@webknjaz
Copy link
Member

@willingc that might work but needs checking. It should be done in a separate PR, though. An alternative would be adding a pattern to linkcheck_ignore if it's found that this problem exists with any StackOverflow links.

@webknjaz
Copy link
Member

@jeanas while that's being sorted out, what do you think about possibly linking https://pip.pypa.io/en/latest/topics/workflow/ / pypa/pip#12503 in follow-ups? Not sure if it'd go in this specific doc, though.

@webknjaz webknjaz added this pull request to the merge queue Feb 29, 2024
Merged via the queue into pypa:main with commit 76e5a15 Feb 29, 2024
5 checks passed
@jeanas jeanas deleted the tool-recommendations branch February 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss how to update the "Tool recommendations" page
9 participants