Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack overflow to linkcheck ignore list #1510

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Feb 26, 2024

Related to failing queries to Stack overflow #1474


📚 Documentation preview 📚: https://python-packaging-user-guide--1510.org.readthedocs.build/en/1510/

@willingc
Copy link
Contributor Author

Thanks for the reviews and guidance @webknjaz. This should ignore the problematic link.

source/conf.py Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

🙄 This is now failing due to pypa/pip#12537 😆

@willingc
Copy link
Contributor Author

Fixed the unrelated failing link @webknjaz.

@webknjaz webknjaz added this pull request to the merge queue Feb 29, 2024
Merged via the queue into pypa:main with commit 241a870 Feb 29, 2024
5 checks passed
@willingc willingc deleted the ignore-so branch February 29, 2024 18:30
@webknjaz
Copy link
Member

Oh, I already made a branch with a different fix that doesn't involve removing the link, just got distracted and didn't open a PR 😃 Will probably do that anyway.

@webknjaz
Copy link
Member

Here I just make a link use an immutable URL to the last commit that had this file #1514. I think it might still be useful in the context it's presented in that document. Removing it should probably be done together with changing that context there.

@willingc
Copy link
Contributor Author

@webknjaz Makes sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants