Remove is_trio_socket #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in: python-trio#170 (comment) there are advantages to having the "is this a trio socket" check be spelled using 'isinstance'. This commit un-deprecates the trio.socket.SocketType name and makes it an abstract class that concrete socket implementations should inherit from, and then gets rid of is_trio_socket since it's now unnecessary.
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 99.24% 99.24% -0.01%
==========================================
Files 86 86
Lines 10327 10306 -21
Branches 726 726
==========================================
- Hits 10249 10228 -21
Misses 61 61
Partials 17 17
Continue to review full report at Codecov.
|
This was referenced Sep 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in:
#170 (comment)
there are advantages to having the "is this a trio socket" check be
spelled using 'isinstance'. This commit un-deprecates the
trio.socket.SocketType name and makes it an abstract class that
concrete socket implementations should inherit from, and then gets rid
of is_trio_socket since it's now unnecessary.