Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove is_trio_socket #326

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Remove is_trio_socket #326

merged 1 commit into from
Sep 15, 2017

Commits on Sep 15, 2017

  1. Remove is_trio_socket 

    As pointed out in:

  python-trio#170 (comment)

there are advantages to having the "is this a trio socket" check be
spelled using 'isinstance'. This commit un-deprecates the
trio.socket.SocketType name and makes it an abstract class that
concrete socket implementations should inherit from, and then gets rid
of is_trio_socket since it's now unnecessary.
    @njsmith
    njsmith committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    9a3141d View commit details
    Browse the repository at this point in the history