Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a Qiskit container for Hybrid Jobs #2

Closed
IceKhan13 opened this issue Feb 22, 2022 · 3 comments
Closed

Implement a Qiskit container for Hybrid Jobs #2

IceKhan13 opened this issue Feb 22, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@IceKhan13
Copy link
Member

IceKhan13 commented Feb 22, 2022

What is the expected behavior?

AWS Braket allows you to use your own containers. We need to implement a Qiskit container for Hybrid Jobs using BYOC.

Reference links:

@IceKhan13 IceKhan13 added enhancement New feature or request help wanted Extra attention is needed labels Feb 22, 2022
@IceKhan13
Copy link
Member Author

@JordanAWS
Copy link
Collaborator

This issue is completed right?

robotAstray referenced this issue in robotAstray/qiskit-braket-provider Jun 13, 2023
kshitijc pushed a commit that referenced this issue Jun 14, 2023
* replacing AWSBraketJob with AmazonBraketTask

* run the notebooks containing AmazonBraketTask

* deprecation warning added for AWSBraketJob class

* formatting fixed

* re-add <JOB_ARN>

* fix breaking changes on /provider/__init__.py and __init__.py

* rename job_id to task_id argument for AmazonBraketTask()

* rename braket_jobs_states to braket_tasks_states

* add task_id method to access the task_id similar to the one we have in the JobV1 class

* adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob'

* formatting test_braket_job.py

* correcting definition of AWSBraketJob

* rewriting line 184 in braket_job.py

* adding class docstring to AWSBraketJob

* standard import 'from warnings import warn'  placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order)

* docstring fix in test_braket_job.py

* assert the job id in test_AWS_job() function in test_braket_job.py

* running how to notebook #0

* running how to notebook #1

* running how to notebook #2

* running how to notebook #3

* running how to notebook number 5

* running tutorial  notebook number 3

* tutorial number 0
robotAstray referenced this issue in robotAstray/qiskit-braket-provider Jun 14, 2023
* replacing AWSBraketJob with AmazonBraketTask

* run the notebooks containing AmazonBraketTask

* deprecation warning added for AWSBraketJob class

* formatting fixed

* re-add <JOB_ARN>

* fix breaking changes on /provider/__init__.py and __init__.py

* rename job_id to task_id argument for AmazonBraketTask()

* rename braket_jobs_states to braket_tasks_states

* add task_id method to access the task_id similar to the one we have in the JobV1 class

* adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob'

* formatting test_braket_job.py

* correcting definition of AWSBraketJob

* rewriting line 184 in braket_job.py

* adding class docstring to AWSBraketJob

* standard import 'from warnings import warn'  placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order)

* docstring fix in test_braket_job.py

* assert the job id in test_AWS_job() function in test_braket_job.py

* running how to notebook #0

* running how to notebook #1

* running how to notebook #2

* running how to notebook #3

* running how to notebook number 5

* running tutorial  notebook number 3

* tutorial number 0
christianbmadsen pushed a commit that referenced this issue Jun 19, 2023
* fix: Updates for Qiskit to Braket circuit conversion (#97)

* Probability to Sample result type

* passes tox lint

* updates toxlint

* fixes observable z error but not passses elint

* unit test added

* final commit with tests

fix: Fallback to JAQCD for device properties (#104)

* fix: Fallback to JAQCD for device properties

* fix: reformat

replacing AWSBraketJob with AmazonBraketTask

run the notebooks containing AmazonBraketTask

deprecation warning added for AWSBraketJob class

formatting fixed

re-add <JOB_ARN>

fix breaking changes on /provider/__init__.py and __init__.py

rename job_id to task_id argument for AmazonBraketTask()

rename braket_jobs_states to braket_tasks_states

add task_id method to access the task_id similar to the one we have in the JobV1 class

adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob'

formatting test_braket_job.py

correcting definition of AWSBraketJob

rewriting line 184 in braket_job.py

adding class docstring to AWSBraketJob

standard import 'from warnings import warn'  placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order)

docstring fix in test_braket_job.py

assert the job id in test_AWS_job() function in test_braket_job.py

running how to notebook #0

running how to notebook #1

running how to notebook #2

running how to notebook #3

running how to notebook number 5

running tutorial  notebook number 3

tutorial number 0

* add separate QUEUED and RUNNING states to task status (#46)

---------

Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>
@christianbmadsen
Copy link
Collaborator

Qiskit is in the base container with amazon-braket/amazon-braket-containers#107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants