Updates for Qiskit to Braket circuit conversion #97

urihan · 2023-05-29T12:31:59Z

Summary

resolves #37 by changing Probability result type to Sample result type.

Details and comments

I have added an additional class, Observable, to the adapter.py file. Also updated the Sampler result type itself by adding an observable z as a parameter.

kshitijc

Thank you for this contribution @urihan! 🚀 Could you please make changes to:

Fix the failing checks
Add unit tests for the source code changes

urihan · 2023-05-31T14:17:12Z

Hi @kshitijc, I am still working on this! I've been stuck on this error called Class 'Observable' has no 'Z' member (no-member) when running 'tox -elint' but it passes 'tox -epy39'.
It is my first time contributing, so I am little lost with this error. Do you have a suggestion on fixing this error? Thank you!

kshitijc · 2023-05-31T22:31:07Z

Hi @kshitijc, I am still working on this! I've been stuck on this error called Class 'Observable' has no 'Z' member (no-member) when running 'tox -elint' but it passes 'tox -epy39'. It is my first time contributing, so I am little lost with this error. Do you have a suggestion on fixing this error? Thank you!

Sorry, I don't see Observable.Z() in your file diff. Could you please point me to the exact location where you are encountering this error?

dakk · 2023-06-01T09:24:40Z

qiskit_braket_provider/providers/adapter.py

@@ -347,11 +347,12 @@ def convert_qiskit_to_braket_circuit(circuit: QuantumCircuit) -> Circuit:
            # TODO: change Probability result type for Sample for proper functioning # pylint:disable=fixme
            # Getting the index from the bit mapping
            quantum_circuit.add_result_type(
-                result_types.Probability(
+                result_types.Sample(
+                    observable=Observable,


Class Observable represents a quantum observable, but which one? Since Probability returns probabilities on computation basis, you have to put the computational basis observable

Hi @dakk, Thank you for your comment. In my first commit, I used observable=Observable.Z() for the Probability; however, it was not passing the tox -elint test. I was changing codes to pass the tox -elint, which is why I got rid of the Z() part causing an error in tox -epy39.
So, I think you are right that I have to put a computational basis but not sure how to pass the tox -elint test..

What was the error of the linter?

@dakk
qiskit_braket_provider/providers/adapter.py:351:31: E1101: Class 'Observable' has no 'Z' member (no-member)

I wonder if we have to use StandardObservable class instead of just Observable class

Right, seems like I have the same version. For that specific error, I added the comment # pylint:disable=fixme next to the code, and I think it might fix it.

But, now I am getting after running tox -elint

lint run-test: commands[3] | mypy --install-types --non-interactive . error: --install-types failed (no mypy cache directory)

I tried to follow this instruction on mypy-install-types-mre, but only produces the same error. I might have to spend more time with it.

Maybe there is a problem with the linter that can't detect dynamically added members; observables are dynamically added to Observable class (from braket side).

There is a workaround:

from braket.circuits import observables observables.Z()

If the problem is the linter, this should work.

Thanks a lot for your help here @dakk!

I wrote a comment here before, but I might have accidentally erased it. Thank you for your help @dakk. I found out I was still getting the same error even after updating with observables.Z(). I was able to get it to work after re-cloning my repository. I decided to just stick with the solution you provided though! I appreciate your help! :)

I wrote a comment here before, but I might have accidentally erased it. Thank you for your help @dakk. I found out I was still getting the same error even after updating with observables.Z(). I was able to get it to work after re-cloning my repository. I decided to just stick with the solution you provided though! I appreciate your help! :)

Oh, that's weird! It was a pleasure!

urihan · 2023-06-05T11:52:25Z

Hi @kshitijc, I have finally fixed failing checks and also added a unit test! It would be great if you could check my submission. Thank you!

kshitijc

Great job @urihan! 👍

…y#97) * Probability to Sample result type * passes tox lint * updates toxlint * fixes observable z error but not passses elint * unit test added * final commit with tests fix: Fallback to JAQCD for device properties (qiskit-community#104) * fix: Fallback to JAQCD for device properties * fix: reformat replacing AWSBraketJob with AmazonBraketTask run the notebooks containing AmazonBraketTask deprecation warning added for AWSBraketJob class formatting fixed re-add <JOB_ARN> fix breaking changes on /provider/__init__.py and __init__.py rename job_id to task_id argument for AmazonBraketTask() rename braket_jobs_states to braket_tasks_states add task_id method to access the task_id similar to the one we have in the JobV1 class adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob' formatting test_braket_job.py correcting definition of AWSBraketJob rewriting line 184 in braket_job.py adding class docstring to AWSBraketJob standard import 'from warnings import warn' placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order) docstring fix in test_braket_job.py assert the job id in test_AWS_job() function in test_braket_job.py running how to notebook #0 running how to notebook #1 running how to notebook #2 running how to notebook #3 running how to notebook number 5 running tutorial notebook number 3 tutorial number 0

* fix: Updates for Qiskit to Braket circuit conversion (#97) * Probability to Sample result type * passes tox lint * updates toxlint * fixes observable z error but not passses elint * unit test added * final commit with tests fix: Fallback to JAQCD for device properties (#104) * fix: Fallback to JAQCD for device properties * fix: reformat replacing AWSBraketJob with AmazonBraketTask run the notebooks containing AmazonBraketTask deprecation warning added for AWSBraketJob class formatting fixed re-add <JOB_ARN> fix breaking changes on /provider/__init__.py and __init__.py rename job_id to task_id argument for AmazonBraketTask() rename braket_jobs_states to braket_tasks_states add task_id method to access the task_id similar to the one we have in the JobV1 class adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob' formatting test_braket_job.py correcting definition of AWSBraketJob rewriting line 184 in braket_job.py adding class docstring to AWSBraketJob standard import 'from warnings import warn' placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order) docstring fix in test_braket_job.py assert the job id in test_AWS_job() function in test_braket_job.py running how to notebook #0 running how to notebook #1 running how to notebook #2 running how to notebook #3 running how to notebook number 5 running tutorial notebook number 3 tutorial number 0 * add separate QUEUED and RUNNING states to task status (#46) --------- Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>

* [UnitaryHack] Enable qiskit transpilation discontinous qubit indices (qiskit-community#108) * convert Rigetti Aspen qubit connectivity continous * Add qiskit transpilation discountinous qubit indices * Add more comments, cleanup * Add more comments, cleanup * Move in Rigetti branching since not require globally * Fix lint * Add better example * Fix docstring * Add mock for rigetti aspen m3 * Enable transpilation test * Fix mypy * [UnitaryHack] Gate Decomposition(qiskit-community#90) added and tested (qiskit-community#111) * implement and test gate decomposition * Implement and Test Gate Decomposition * addressed comments in previous PR * Adding separate QUEUED and RUNNING states to task status (qiskit-community#110) * fix: Updates for Qiskit to Braket circuit conversion (qiskit-community#97) * Probability to Sample result type * passes tox lint * updates toxlint * fixes observable z error but not passses elint * unit test added * final commit with tests fix: Fallback to JAQCD for device properties (qiskit-community#104) * fix: Fallback to JAQCD for device properties * fix: reformat replacing AWSBraketJob with AmazonBraketTask run the notebooks containing AmazonBraketTask deprecation warning added for AWSBraketJob class formatting fixed re-add <JOB_ARN> fix breaking changes on /provider/__init__.py and __init__.py rename job_id to task_id argument for AmazonBraketTask() rename braket_jobs_states to braket_tasks_states add task_id method to access the task_id similar to the one we have in the JobV1 class adding tests for new class 'AmazonBraketTask' and old class 'AWSBraketJob' formatting test_braket_job.py correcting definition of AWSBraketJob rewriting line 184 in braket_job.py adding class docstring to AWSBraketJob standard import 'from warnings import warn' placed before 'from braket.aws import AwsQuantumTask' (wrong-import-order) docstring fix in test_braket_job.py assert the job id in test_AWS_job() function in test_braket_job.py running how to notebook #0 running how to notebook #1 running how to notebook #2 running how to notebook #3 running how to notebook number 5 running tutorial notebook number 3 tutorial number 0 * add separate QUEUED and RUNNING states to task status (qiskit-community#46) --------- Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com> --------- Co-authored-by: WingCode <smallstar1234@gmail.com> Co-authored-by: Gmontes01 <118773601+Gmontes01@users.noreply.github.com> Co-authored-by: Yuri Han <45699207+urihan@users.noreply.github.com>

Probability to Sample result type

ee6e3a0

kshitijc reviewed May 30, 2023

View reviewed changes

urihan added 2 commits May 31, 2023 18:20

passes tox lint

45f6eba

updates toxlint

18a8f24

dakk reviewed Jun 1, 2023

View reviewed changes

urihan and others added 4 commits June 2, 2023 15:59

fixes observable z error but not passses elint

04df9dc

Merge branch 'main' into branch1

fe16bbf

unit test added

7213c7d

final commit with tests

cff2d84

kshitijc approved these changes Jun 5, 2023

View reviewed changes

kshitijc merged commit 5fef143 into qiskit-community:main Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for Qiskit to Braket circuit conversion #97

Updates for Qiskit to Braket circuit conversion #97

urihan commented May 29, 2023 •

edited

Loading

kshitijc left a comment

urihan commented May 31, 2023

kshitijc commented May 31, 2023

dakk Jun 1, 2023 •

edited

Loading

urihan Jun 1, 2023 •

edited

Loading

dakk Jun 1, 2023

urihan Jun 1, 2023 •

edited

Loading

urihan Jun 1, 2023

urihan Jun 1, 2023 •

edited

Loading

dakk Jun 1, 2023

kshitijc Jun 5, 2023

urihan Jun 6, 2023

dakk Jun 6, 2023

urihan commented Jun 5, 2023 •

edited

Loading

kshitijc left a comment

Updates for Qiskit to Braket circuit conversion #97

Updates for Qiskit to Braket circuit conversion #97

Conversation

urihan commented May 29, 2023 • edited Loading

Summary

Details and comments

kshitijc left a comment

Choose a reason for hiding this comment

urihan commented May 31, 2023

kshitijc commented May 31, 2023

dakk Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

urihan Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

dakk Jun 1, 2023

Choose a reason for hiding this comment

urihan Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

urihan Jun 1, 2023

Choose a reason for hiding this comment

urihan Jun 1, 2023 • edited Loading

Choose a reason for hiding this comment

dakk Jun 1, 2023

Choose a reason for hiding this comment

kshitijc Jun 5, 2023

Choose a reason for hiding this comment

urihan Jun 6, 2023

Choose a reason for hiding this comment

dakk Jun 6, 2023

Choose a reason for hiding this comment

urihan commented Jun 5, 2023 • edited Loading

kshitijc left a comment

Choose a reason for hiding this comment

urihan commented May 29, 2023 •

edited

Loading

dakk Jun 1, 2023 •

edited

Loading

urihan Jun 1, 2023 •

edited

Loading

urihan Jun 1, 2023 •

edited

Loading

urihan Jun 1, 2023 •

edited

Loading

urihan commented Jun 5, 2023 •

edited

Loading