Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of qiskit ParameterExpressions for circuit conversion: qiskit to braket #139

Merged
merged 21 commits into from
Feb 12, 2024

Commits on Jan 26, 2024

  1. Enable the use of qiskit ParameterVector for circuit conversion qiski…

    …t to braket
    
    This modification allows users to convert their qiskit circuit object that was parametrized with a qiskit ParameterVector to convert it to a braket circuit.
    lukasvoss committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    414edd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0c14d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Improve naming of FreeParameterExpression

    By default, qiskit names elements of a ``ParameterVector`` are named like this 'a[<index>]'. The '[]' parentheses are not supported by the QASM 3 syntax which leads to an error when trying to run a Braket Circuit with free parameters following the '[]'-naming. Therefore, I ensured that these will be removed before the ``ParamterExpression`` is passed to create a FreeParameterExpression out of it.
    lukasvoss committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    1daed0f View commit details
    Browse the repository at this point in the history
  2. add import sympify

    lukasvoss committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    0c5c07e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Ensure compatibility with QASM 3 syntax when using single-entry qiski…

    …t ``ParameterVector``
    
    Assume this example: A one-qubit qiskit circuit with the parametrized Rx-gate as its only operation.
    When using a qiskit ``ParameterVector``` of length 1 (i.e., params = ParameterVector("a", 1)), this would lead to the Parameter being called 'a[0]' which leads to a QASM 3 syntax error when trying to run the circuit.
    The proposed changes ensure that the squared-parentheses '[]' are being removed in the parameter names.
    lukasvoss committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    06fd7fe View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    8eebdde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8eeaf40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d77fe2c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e3d835 View commit details
    Browse the repository at this point in the history
  5. draft: validate name

    jcjaskula-aws committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    07140ff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    346d42d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    de59b62 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    66c0849 View commit details
    Browse the repository at this point in the history
  9. fix merge

    jcjaskula-aws committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2477afa View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Configuration menu
    Copy the full SHA
    52bfed6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9c9a58 View commit details
    Browse the repository at this point in the history
  3. do not use sympify

    jcjaskula-aws committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    034cd34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    418642a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    25eab47 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. fix docstring

    jcjaskula-aws committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    af91a09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0684409 View commit details
    Browse the repository at this point in the history