Enable use of qiskit ParameterExpressions for circuit conversion: qiskit to braket

[lukasvoss]

Summary

• Users that work with a qiskit circuit that was parameterized using a qiskit ParameterExpression can now convert their qiskit circuit to a braket circuit using the convert_qiskit_to_braket_circuit function.

Details

• A qiskit ParameterExpression could be for example a qiskit Parameter object with a constant (i.e., float) offset. This could be relevant if one uses a constant baseline for a rotation value on which a variable Parameter then gets added.

This could look something like this for a parametrized CNOT gate in qiskit:

from qiskit.circuit import QuantumCircuit, QuantumRegister
from qiskit_braket_provider.providers import adapter

q_reg = QuantumRegister(2)
my_qc = QuantumCircuit(q_reg, name="custom_cx")

baseline = np.pi * np.array([0.1, 0.3, 0.7, 0.3, -0.4, 0.4, -0.3])
params = ParameterVector(name='a', length=7)

my_qc.u(
    baseline[0] + params[0], # This 'sum' constitutes a qiskit ParameterExpression
    baseline[1] + params[1],
    baseline[2] + params[2],
    q_reg[0],
)
my_qc.u(
    baseline[3] + params[3],
    baseline[4] + params[4],
    baseline[5] + params[5],
    q_reg[1],
)
my_qc.rzx(baseline[6] + params[6], q_reg[0], q_reg[1])

braket_circuit = adapter.convert_qiskit_to_braket_circuit(my_qc)

[CLAassistant]

All committers have signed the CLA.

[laurencap]

Hi @lukasvoss, thank you for the contribution! This is a great feature. Please add some tests that cover the lines you've added and show that your changes work correctly.

[lukasvoss]

Dear Lauren, dear Jean-Christophe,
I have implement some changes that are solving the errors arising from the qiskit naming convention of ParameterVector elements by removing the squared-parenthesis from the parameter name.

[jcjaskula-aws]

On top of the comment above, we should also have tests in test_adapter.py. test_convert_parametric_qiskit_to_braket_circuit should be a good one to duplicate and adapt with ParameterExpression and ParameterVector.

[jcjaskula-aws]

@lukasvoss I took the liberty to push commits to your PR. Let me know if you are satisfied with the current implementation.

[lukasvoss]

@jcjaskula-aws Thanks for your contribution, looks good to me!

[lukasvoss]

Will now be handled with renaming parameter values, adjusting for QASM3 compatibility by removing parenthesis and controlling for duplicates in the parameter naming.

[lukasvoss]

@ALL: Thanks for all your contributions!