Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of qiskit ParameterExpressions for circuit conversion: qiskit to braket #139

Merged
merged 21 commits into from
Feb 12, 2024
Merged
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions qiskit_braket_provider/providers/adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
gates,
observables,
)
from braket.parametric.free_parameter_expression import FreeParameterExpression
from braket.device_schema import (
DeviceActionType,
GateModelQpuParadigmProperties,
Expand All @@ -26,10 +27,11 @@
from braket.devices import LocalSimulator

from numpy import pi
from sympy import sympify

from qiskit import QuantumCircuit, transpile
from qiskit.circuit import Instruction as QiskitInstruction
from qiskit.circuit import Measure, Parameter
from qiskit.circuit import Measure, Parameter, ParameterExpression
from qiskit.circuit.library import (
CCXGate,
CPhaseGate,
Expand Down Expand Up @@ -450,8 +452,12 @@ def convert_qiskit_to_braket_circuit(circuit: QuantumCircuit) -> Circuit:

for i, param in enumerate(params):
if isinstance(param, Parameter):
params[i] = FreeParameter(param.name)

cleaned_param_name = str(param._symbol_expr).replace('[', '').replace(']', '')
params[i] = FreeParameter(cleaned_param_name)
elif isinstance(param, ParameterExpression):
cleaned_expr_str = str(param._symbol_expr).replace('[', '').replace(']', '')
params[i] = FreeParameterExpression(sympify(cleaned_expr_str))
jcjaskula-aws marked this conversation as resolved.
Show resolved Hide resolved

for gate in qiskit_gate_names_to_braket_gates[gate_name](*params):
instruction = Instruction(
# Getting the index from the bit mapping
Expand Down