Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): migrate from enzyme, react 18 prep #227

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 12, 2023

What's included

  • build(babel): update presets
  • refactor(testing): migrate from enzyme

Notes

  • removes testing blockers for React 18 by migrating off of enzyme
  • if the existing unit testing is leverage as a baseline the related snapshot updates should help any future migration towards a newer or streamlined interface
  • react 18 prep is related to the next Patternfly React release
  • attempts to normalize and remove unnecessary tests around "connected components"

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

There is a minor build modification included with these updates.

  1. update the NPM packages with $ yarn
  2. $ yarn start:stage
  3. confirm the related interface runs and displays as expected.

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

* build, babel dist, testing presets, browser targets
@cdcabrera cdcabrera force-pushed the 20230705-testing-migrate-enzyme branch 5 times, most recently from 33638c5 to 92f6bed Compare July 17, 2023 19:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #227 (45b8401) into dev (d35d1d2) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 45b8401 differs from pull request most recent head 3526f51. Consider uploading reports for the commit 3526f51 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
+ Coverage   84.02%   84.18%   +0.15%     
==========================================
  Files         116      116              
  Lines        3775     3775              
  Branches     1339     1339              
==========================================
+ Hits         3172     3178       +6     
+ Misses        538      536       -2     
+ Partials       65       61       -4     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d1d2...3526f51. Read the comment docs.

@cdcabrera cdcabrera force-pushed the 20230705-testing-migrate-enzyme branch from c428c74 to a4e03e2 Compare July 17, 2023 19:27
@cdcabrera cdcabrera marked this pull request as ready for review July 17, 2023 19:35
@cdcabrera cdcabrera force-pushed the 20230705-testing-migrate-enzyme branch from c336195 to 45b8401 Compare July 18, 2023 17:11
@cdcabrera cdcabrera force-pushed the 20230705-testing-migrate-enzyme branch from 45b8401 to 3526f51 Compare July 18, 2023 17:17
@cdcabrera cdcabrera merged commit 5443987 into quipucords:dev Jul 18, 2023
3 checks passed
cdcabrera added a commit that referenced this pull request Jul 20, 2023
cdcabrera added a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants