Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): react testing, handler context wrappers #229

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 19, 2023

What's included

  • refactor(testing): react testing, handler context wrappers

Notes

  • expands the React testing Jest handlers to include context in the returned results

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing
related #230 #227

* jest, expand handlers to apply context on results
* scansContext, test adjust for updated handler
@codecov-commenter
Copy link

Codecov Report

Merging #229 (43d473b) into dev (5443987) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #229   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files         116      116           
  Lines        3775     3775           
  Branches     1339     1339           
=======================================
  Hits         3178     3178           
  Misses        536      536           
  Partials       61       61           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5443987...43d473b. Read the comment docs.

@cdcabrera cdcabrera merged commit 3eda8b1 into quipucords:dev Jul 19, 2023
3 checks passed
cdcabrera added a commit that referenced this pull request Jul 20, 2023
* jest, expand handlers to apply context on results
* scansContext, test adjust for updated handler
cdcabrera added a commit that referenced this pull request Jul 31, 2023
* jest, expand handlers to apply context on results
* scansContext, test adjust for updated handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants