Native AMQP follow ups #10662
Merged
Native AMQP follow ups #10662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
native-amqp-follow-ups
branch
from
ef9ab12
to
1594518
Compare
|
Tests fail due to #10657 |
acogoluegnes
approved these changes
Mar 4, 2024
If the server initiates the detach due to an error condition, it destroys and therefore forgets the link. This should be okay because accroding to section 2.6.5: "When an error occurs at a link endpoint, the endpoint MUST be detached with appropriate error information supplied in the error field of the detach frame. The link endpoint MUST then be destroyed." It is also valid that the client replies with a detach: "If any input (other than a detach) related to the endpoint either via the input handle or delivery-ids be received, the session MUST be terminated with an errant-link session-error." In this case, the server must not reply again with (i.e do not sent a 3rd) detach.
for default and pre-declared exchanges to save copying
the #exchange{} record (i.e. save an ETS lookup call) on
every received message.
The default and pre-declared exchanges are protected from deletion and
modification. Exchange routing decorators are not used in tier 1 plugins
and in no open source tier 2 plugin.
when message was published to a stream via the stream protocol. Fixes the following test: ``` ./mvnw test -Dtest=AmqpInteroperabilityTest#publishToStreamConsumeFromStreamQueue ```
michaelklishin
force-pushed
the
native-amqp-follow-ups
branch
from
1594518
to
118d846
Compare
|
The forced push is a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #9022.