Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native AMQP follow ups #10662

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Native AMQP follow ups #10662

merged 3 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. Fix bug where server sends a 3rd detach. 

    If the server initiates the detach due to an error condition, it
destroys and therefore forgets the link.

This should be okay because accroding to section 2.6.5:
"When an error occurs at a link endpoint, the endpoint MUST be detached
with appropriate error information supplied in the error field of the detach
frame. The link endpoint MUST then be destroyed."

It is also valid that the client replies with a detach:
"If any input (other than a detach) related to the endpoint either via
the input handle or delivery-ids be received, the session MUST be
terminated with an errant-link session-error."

In this case, the server must not reply again with (i.e do not sent a 3rd)
detach.
    @ansd @michaelklishin
    ansd authored and michaelklishin committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5c61772 View commit details
    Browse the repository at this point in the history

  2. Cache exchange record 

    for default and pre-declared exchanges to save copying
the #exchange{} record (i.e. save an ETS lookup call) on
every received message.

The default and pre-declared exchanges are protected from deletion and
modification. Exchange routing decorators are not used in tier 1 plugins
and in no open source tier 2 plugin.
    @ansd @michaelklishin
    ansd authored and michaelklishin committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    99dd040 View commit details
    Browse the repository at this point in the history

  3. Fix routing key for AMQP 0.9.1 reading from a stream 

    when message was published to a stream via the stream protocol.

Fixes the following test:
```
./mvnw test -Dtest=AmqpInteroperabilityTest#publishToStreamConsumeFromStreamQueue
```
    @ansd @michaelklishin
    ansd authored and michaelklishin committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    118d846 View commit details
    Browse the repository at this point in the history