-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off BuildBuddy integration #11343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjk25
force-pushed
the
rin/disable-buildbuddy
branch
from
May 29, 2024 14:02
38d1e25
to
b638fe2
Compare
parallelize over the plugins
pjk25
force-pushed
the
rin/disable-buildbuddy
branch
from
May 30, 2024 10:00
fc5b5b2
to
4b1a4b2
Compare
pjk25
force-pushed
the
rin/disable-buildbuddy
branch
from
May 30, 2024 12:32
3a3b003
to
b174588
Compare
when run on the actions runner
pjk25
force-pushed
the
rin/disable-buildbuddy
branch
from
May 30, 2024 12:38
b174588
to
72a39a0
Compare
rabbit's tests are large and slow, but parallizing across deps/rabbit suites requires more complicated templating
grouping all the large tests is clearly not ideal, but at least this gives us subgroups that don't require us to know the names of all the suites
we don't capture the logs as artifacts, because secrets would be leaked, but github actions should redact these values from the console for us
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Builds now execute on the github actions workers, using Google Cloud Storage (GCS) as a cache (cherry picked from commit a6874e3) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # deps/rabbitmq_peer_discovery_consul/test/system_SUITE_data/consul.hcl
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Accidentally left out of #11343 (cherry picked from commit bdd18ed) # Conflicts: # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml (cherry picked from commit 57dba90)
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Accidentally left out of #11343 (cherry picked from commit bdd18ed) # Conflicts: # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml (cherry picked from commit 57dba90) (cherry picked from commit 8754bb6)
michaelklishin
added a commit
that referenced
this pull request
Jun 7, 2024
Turn off BuildBuddy integration (backport #11343)
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Builds now execute on the github actions workers, using Google Cloud Storage (GCS) as a cache (cherry picked from commit a6874e3) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # deps/rabbitmq_peer_discovery_consul/test/system_SUITE_data/consul.hcl (cherry picked from commit 2c62185) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # MODULE.bazel # bazel/platforms/BUILD.bazel
pjk25
added a commit
that referenced
this pull request
Jun 10, 2024
…11416) * Turn off BuildBuddy integration (#11343) Builds now execute on the github actions workers, using Google Cloud Storage (GCS) as a cache (cherry picked from commit a6874e3) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # deps/rabbitmq_peer_discovery_consul/test/system_SUITE_data/consul.hcl (cherry picked from commit 2c62185) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # MODULE.bazel # bazel/platforms/BUILD.bazel * fixup backport (cherry picked from commit dd62ac1) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml * remove rabbitmq_amqp_client tests from this branch as the plugin does not exist here (cherry picked from commit 28ee2dd) # Conflicts: # .github/workflows/test-mixed-versions.yaml * Reduce bazel sandbox for rabbitmq_amqp1_0 tests in CI since they use java (cherry picked from commit 0d5c0e5) * Install daemonize as needed in the peer_discovery_etcd suite (cherry picked from commit 23f6e5c) * fixup backport * oauth2_client does not exist on this branch and rabbitmq_prelaunch will run as part of the rabbit shards * Use erlang 25.0/elixir 1.14 for mixed version tests --------- Co-authored-by: Rin Kuryloski <rin.kuryloski@broadcom.com>
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2024
…11416) * Turn off BuildBuddy integration (#11343) Builds now execute on the github actions workers, using Google Cloud Storage (GCS) as a cache (cherry picked from commit a6874e3) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # deps/rabbitmq_peer_discovery_consul/test/system_SUITE_data/consul.hcl (cherry picked from commit 2c62185) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # MODULE.bazel # bazel/platforms/BUILD.bazel * fixup backport (cherry picked from commit dd62ac1) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml * remove rabbitmq_amqp_client tests from this branch as the plugin does not exist here (cherry picked from commit 28ee2dd) # Conflicts: # .github/workflows/test-mixed-versions.yaml * Reduce bazel sandbox for rabbitmq_amqp1_0 tests in CI since they use java (cherry picked from commit 0d5c0e5) * Install daemonize as needed in the peer_discovery_etcd suite (cherry picked from commit 23f6e5c) * fixup backport * oauth2_client does not exist on this branch and rabbitmq_prelaunch will run as part of the rabbit shards * Use erlang 25.0/elixir 1.14 for mixed version tests --------- Co-authored-by: Rin Kuryloski <rin.kuryloski@broadcom.com> (cherry picked from commit c78563a) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # bazel/platforms/BUILD.bazel
pjk25
added a commit
that referenced
this pull request
Jun 12, 2024
…backport #11416) (#11424) * Turn off BuildBuddy integration (backport #11343) (backport #11390) (#11416) * Turn off BuildBuddy integration (#11343) Builds now execute on the github actions workers, using Google Cloud Storage (GCS) as a cache (cherry picked from commit a6874e3) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # deps/rabbitmq_peer_discovery_consul/test/system_SUITE_data/consul.hcl (cherry picked from commit 2c62185) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/templates/test-mixed-versions.template.yaml # .github/workflows/templates/test.template.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # MODULE.bazel # bazel/platforms/BUILD.bazel * fixup backport (cherry picked from commit dd62ac1) # Conflicts: # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml * remove rabbitmq_amqp_client tests from this branch as the plugin does not exist here (cherry picked from commit 28ee2dd) # Conflicts: # .github/workflows/test-mixed-versions.yaml * Reduce bazel sandbox for rabbitmq_amqp1_0 tests in CI since they use java (cherry picked from commit 0d5c0e5) * Install daemonize as needed in the peer_discovery_etcd suite (cherry picked from commit 23f6e5c) * fixup backport * oauth2_client does not exist on this branch and rabbitmq_prelaunch will run as part of the rabbit shards * Use erlang 25.0/elixir 1.14 for mixed version tests --------- Co-authored-by: Rin Kuryloski <rin.kuryloski@broadcom.com> (cherry picked from commit c78563a) # Conflicts: # .bazelrc # .github/workflows/rabbitmq_peer_discovery_aws.yaml # .github/workflows/test-mixed-versions.yaml # .github/workflows/test.yaml # .github/workflows/update-elixir-patches.yaml # .github/workflows/update-otp-patches.yaml # MODULE.bazel # WORKSPACE # bazel/platforms/BUILD.bazel * fixup backport * removed rabbitmqctl_check_formatted We only apply it to later elixirs * no need to have RABBITMQ_METADATA_STORE in the matrix * debug rabbitmq_ct_helpers dialyzer error * try to skip the broken plt rules on github actions for now * try target_compatible_with * exec_compatible_with is problematic the way we cquery as it results in explicitly requesting the target instead try just a manual tag * It seems dialyzing against elixir doesn't work with setup-beam --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rin Kuryloski <rin.kuryloski@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of GCS for remote cache, and github actions runners for execution