mc: increase utf8 scanning limit for longstr conversions. #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AMQP 0.9.1 longstr type is problematic as it can contain arbitrary binary data but is typically used for utf8 by users. The current conversion into AMQP avoids scanning arbitrarily large longstr to see if they only contain valid utf8 by treating all longstr data longer than 255 bytes as binary. This is in hindsight too strict and thus this commit increases the scanning limit to 4096 bytes - enough to cover the vast majority of AMQP 0.9.1 header values. This change also conversts the AMQP binary types into longstr to ensure that existing data (held in streams for example) is converted to an AMQP 0.9.1 type most likely what the user intended.
... that's perfectly fine since according to the AMQP 0.9.1 spec:
|
ansd
approved these changes
Jul 15, 2024
|
Looks like if both labels are set, our greatly simplified Mergify backporting setup does nothing 😅 @Mergifyio backport v4.0.x v3.13.x |
|
@Mergifyio backport v4.0.x v3.13.x |
✅ Backports have been created
|
This was referenced Jul 17, 2024
acogoluegnes
added a commit
that referenced
this pull request
Jul 17, 2024
mc: increase utf8 scanning limit for longstr conversions. (backport #11715)
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Jul 17, 2024
github-actions bot
pushed a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Jul 17, 2024
acogoluegnes
added a commit
that referenced
this pull request
Jul 17, 2024
mc: increase utf8 scanning limit for longstr conversions. (backport #11715)
Gsantomaggio
added a commit
to rabbitmq/rabbitmq-stream-dotnet-client
that referenced
this pull request
Jul 25, 2024
Update the test conversion from amqp 091 to stream due of rabbitmq/rabbitmq-server#11715 Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
Gsantomaggio
added a commit
to rabbitmq/rabbitmq-stream-dotnet-client
that referenced
this pull request
Jul 25, 2024
* Update RabbitMQ version and the test * Update the test conversion from amqp 091 to stream due of rabbitmq/rabbitmq-server#11715 --------- Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Jul 26, 2024
github-actions bot
pushed a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMQP 0.9.1 longstr type is problematic as it can contain arbitrary binary data but is typically used for utf8 by users.
The current conversion into AMQP avoids scanning arbitrarily large longstr to see if they only contain valid utf8 by treating all longstr data longer than 255 bytes as binary. This is in hindsight too strict and thus this commit increases the scanning limit to 4096 bytes - enough to cover the vast majority of AMQP 0.9.1 header values.
This change also conversts the AMQP binary types into longstr to ensure that existing data (held in streams for example) is converted to an AMQP 0.9.1 type most likely what the user intended.