Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc: increase utf8 scanning limit for longstr conversions. #11715

Merged
merged 1 commit into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. mc: increase utf8 scanning limit for longstr conversions.

    The AMQP 0.9.1 longstr type is problematic as it can contain arbitrary
    binary data but is typically used for utf8 by users.
    
    The current conversion into AMQP avoids scanning arbitrarily large
    longstr to see if they only contain valid utf8 by treating all
    longstr data longer than 255 bytes as binary. This is in hindsight
    too strict and thus this commit increases the scanning limit to
    4096 bytes - enough to cover the vast majority of AMQP 0.9.1 header
    values.
    
    This change also conversts the AMQP binary types into longstr to
    ensure that existing data (held in streams for example) is converted
    to an AMQP 0.9.1 type most likely what the user intended.
    kjnilsson committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c342f27 View commit details
    Browse the repository at this point in the history