-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update a lot of packages to fix ledger issues with chromedriver #1702
Conversation
694c60f
to
9a3c609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have any takeaways when you attempted to get those tests working? Any idea what's going on? Merging those skips into master makes me nervous because then we'd be able to add more bugs to those flows without knowing.
@@ -12,4 +12,4 @@ runs: | |||
gh-access-token: ${{ inputs.gh-access-token }} | |||
- name: Install chrome | |||
shell: 'bash' | |||
run: npx @puppeteer/browsers install chrome@121 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to keep repinning this? wondering if we should try to be @latest again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- yeah I originally changed it to that but some other errors happened and bruno pinned it. i am honestly down for either but doing @latest does require we update chromedriver regularly.
- takeaways when trying to fix tests were I think we merged something in that broke it. the only thing currently broken is the actual executing swap. Here is the error i was seeing:
- my thought was since bx is moving slow and this release should get out we can unblock CI and then solve it afterwards
Closed in favor of: #1704 |
What changed (plus any additional context for devs)