Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e #1704

Merged
merged 14 commits into from
Sep 18, 2024
Merged

e2e #1704

merged 14 commits into from
Sep 18, 2024

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Sep 18, 2024 •
edited
Loading

This is a surrogate PR for #1702 without the skipped tests and some small e2e tweaks.

What Changed

  • Updated packages to resolve Ledger issues with chromedriver
  • Bump chrome driver to 128 on CI
  • Return data in gas hooks to prevent react-query error in the console after each swap input value changes

PoW

Screenshot 2024-09-18 at 3 21 16 PM

What to Test

  • QA should run regression on Ledger flow to verify there are no issues with the dependency updates.
  • Attempt to run the e2e suite locally with chrome version 128 or above and ensure that the tests run correctly, pass, and that there are no additional issues with local e2e.

@derHowie derHowie changed the base branch from master to brody/update-packages September 18, 2024 16:04
@derHowie derHowie changed the base branch from brody/update-packages to master September 18, 2024 17:47
@derHowie derHowie marked this pull request as ready for review September 18, 2024 17:48
@BrodyHughes BrodyHughes self-requested a review September 18, 2024 17:57
BrodyHughes
BrodyHughes approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

brunobar79
brunobar79 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@BrodyHughes BrodyHughes mentioned this pull request Sep 18, 2024
Closed
@derHowie derHowie merged commit d8b5844 into master Sep 18, 2024
12 checks passed
@derHowie derHowie deleted the @chris/e2e-fixes branch September 18, 2024 19:25
DanielSinclair
DanielSinclair reviewed Sep 18, 2024
View reviewed changes
package.json
@@ -96,8 +96,10 @@
"@ethersproject/transactions": "5.7.0",
"@ethersproject/units": "5.7.0",
"@ethersproject/wallet": "5.7.0",
"@ledgerhq/hw-app-eth": "6.35.3",
"@ledgerhq/evm-tools": "1.2.0",
"@ledgerhq/hw-app-eth": "6.38.0",
"@ledgerhq/hw-transport-webhid": "6.28.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrodyHughes Is there a reason we dropped hw-transport-webhid to 6.28? 6.29 is compatible with the Flex devices

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason no. i don't remember specifying 28 when i bumped. i imagine bumping to 29 is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully this fixes e2e and bumping is easy now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSinclair DanielSinclair DanielSinclair left review comments

@BrodyHughes BrodyHughes BrodyHughes approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derHowie @brunobar79 @DanielSinclair @BrodyHughes