Accept r-value references in convert_table_for_return(): #10131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cudf::jni::convert_table_for_return()` is usually used on tables returned from a libcudf API call.
It currently requires an l-value reference for its table argument. This necessitates parking the
result of libcudf call in an avoidable temp variable.
This commit adds the option to use an r-value reference. This allows table expressions to be used
directly, reducing clutter.
Note:
1. The previous signature is retained, because not all call sites can use the r-value interface
cleanly. (E.g. when the libcudf call is complex.)
2. The third argument (vector<unique_ptr<column>>) has been converted from l-ref to r-ref,
so that an empty default can be introduced.
This commit also includes minor code cleanup in the periphery of calls to `convert_table_for_return()`.
Call it collateral damage.
mythrocks
added
code quality
improvement
Added/Fixed jpointerArray::begin()/end() signatures.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10131 +/- ##
================================================
+ Coverage 10.37% 10.43% +0.05%
================================================
Files 119 119
Lines 20149 20594 +445
================================================
+ Hits 2091 2148 +57
- Misses 18058 18446 +388
Continue to review full report at Codecov.
|
jlowe
reviewed
Jan 26, 2022
jlowe
approved these changes
Jan 26, 2022
|
One more follow-up remains: To use |
|
Resolved merge conflicts. This will be checked in after the CI completes. |
|
Rerun tests |
|
@gpucibot merge |
|
This has now been merged. Thanks for the reviews, @jlowe. I'll have to delay the remaining follow up till next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cudf::jni::convert_table_for_return()is usually used on tables returned from a libcudf API call.It currently requires an l-value reference for its table argument. This necessitates parking the result of libcudf call in an avoidable temp variable.
This commit adds the option to use an r-value reference. This allows table expressions to be used directly, reducing clutter.
Note:
interface cleanly. (E.g. when the libcudf call is complex.)
so that an empty default can be introduced.
This commit also includes minor code cleanup in the periphery of calls to
convert_table_for_return().