Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept r-value references in convert_table_for_return(): #10131

Merged
merged 6 commits into from
Jan 27, 2022

Commits on Jan 26, 2022

  1. Accept r-value references in convert_table_for_return():

    `cudf::jni::convert_table_for_return()` is usually used on tables returned from a libcudf API call.
    It currently requires an l-value reference for its table argument. This necessitates parking the
    result of libcudf call in an avoidable temp variable.
    This commit adds the option to use an r-value reference. This allows table expressions to be used
    directly, reducing clutter.
    
    Note:
      1. The previous signature is retained, because not all call sites can use the r-value interface
         cleanly. (E.g. when the libcudf call is complex.)
      2. The third argument (vector<unique_ptr<column>>) has been converted from l-ref to r-ref,
         so that an empty default can be introduced.
    
    This commit also includes minor code cleanup in the periphery of calls to `convert_table_for_return()`.
    Call it collateral damage.
    mythrocks committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    0c8b172 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99a9419 View commit details
    Browse the repository at this point in the history
  3. Finished with TableJni.cpp

    Added/Fixed jpointerArray::begin()/end() signatures.
    mythrocks committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    d0d3aa7 View commit details
    Browse the repository at this point in the history
  4. Const all the things.

    mythrocks committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    28d26df View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Configuration menu
    Copy the full SHA
    bb7ffd5 View commit details
    Browse the repository at this point in the history
  2. Formatting.

    mythrocks committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    c5340c2 View commit details
    Browse the repository at this point in the history