Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: reset_index tests failing: "insert() got an unexpected keyword argument 'name'" #1427

Closed
jameslamb opened this issue Aug 1, 2024 · 0 comments · Fixed by #1428
Closed
Labels
bug Something isn't working

Comments

@jameslamb
Copy link
Member

Version

24.10

On which installation method(s) does this occur?

No response

Describe the issue

On 24.10, several unit tests are failing:

FAILED tests/test_geodataframe.py::test_reset_index[-0-False-False-None] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[-0-False-False-0] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[-0-False-False-1] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[-1-False-False-None] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[-1-False-False-0] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[-1-False-False-1] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-0-False-False-None] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-0-False-False-0] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-0-False-False-1] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-1-False-False-None] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-1-False-False-0] - TypeError: insert() got an unexpected keyword argument 'name'
FAILED tests/test_geodataframe.py::test_reset_index[some_lv-1-False-False-1] - TypeError: insert() got an unexpected keyword argument 'name'

(build link)

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

Not observing this on 24.08, so I believe it's 24.10-specific.

This is happening for both wheels and conda packages, across all combinations of CPU architecture, Python version, and CUDA version tested.

@jameslamb jameslamb added the bug Something isn't working label Aug 1, 2024
@rapids-bot rapids-bot bot closed this as completed in #1428 Aug 7, 2024
@rapids-bot rapids-bot bot closed this as completed in 3906fb9 Aug 7, 2024
rapids-bot bot pushed a commit that referenced this issue Aug 7, 2024
…orkflow (#1429)

closes #1426

It appears there was a change in 24.08 that broke a notebook demonstrating a `merge` on two geometry columns. It seems like the merge result tries to reconstruct a `GeoDataFrame` from a `dict[Any, GeoSeries | Series]` but the `Series.index` alignment requires the types to be recognized cudf types (not `"geometry"`)

I don't think this alignment is entirely necessary though since it goes through the `_split_out_geometry_columns`/`_recombine_columns` methods which appears to be used on operations that maintain row ordering so index alignment isn't required.

This PR instead passes a `dict[Any, GeoColumn | Column]` to `cudf.DataFrame._from_data` given that this row ordering is preserved.

(This PR also includes the fix for #1427)

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant