-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node version #187
Bump node version #187
Conversation
This was discussed here: I'm unsure if we want to bump Node to 16 at this stage as we won't be testing on 14 anymore. But as 18 entered LTS, it's probably worth to switch at this stage |
current version of react native support node 16 https://github.com/facebook/react-native/blob/main/.node-version so it will be great if this could be merge |
I am inclined we directly bump to 18 |
I change it to 18 |
I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported |
Node.js 16 will EOL in 2023. 18 will in 2025 with more features and newer v8 (comprehensive js features). Also if #188 got merged, they can use n to switch node version easily. |
Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Ref - react-native-community/docker-android#187 cc @ramonmedel @cortinico @gengjiawen
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - #34171 - #32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: #35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
As this got merged: Please go ahead and bump to 16.x If you need 18 -> Let's merge #188 instead |
you mean bump to 18.x ? |
Nope, I meant bump to 16.x
We want the docker container to run on the minimum supported version of Node, which was bumped from 14 -> 16. |
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - facebook#34171 - facebook#32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: facebook#35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - facebook#34171 - facebook#32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: facebook#35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
Bump node version to 16.x
as defined in .node-version in react native