-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use node version manager #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to add a node version manager, I would prefer n. This would be more less intrusive and easy (use npm to install n)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would refrain from adding a node version manager in the container frankly. Version managers are user tools. The idea behind a container is to have a fixed set of dependencies that are used to build a given tool. |
It only added one npm package in the end, the cost is very small. In the long run, I think this is very useful for user-land to do matrix testing(Node.js latest, lts, minimum) |
agree w a minimal container but also the small cost of node 19's out (working for me) and others testing matrices ahead's good for long-term contribution (node 20 next easter) noticed |
Thx for contribution |
No description provided.