Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use node version manager #188

Merged
merged 3 commits into from
Nov 25, 2022
Merged

use node version manager #188

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00134ac
use n node version manager
krudos Nov 21, 2022
81711ba
remove extra install of node
krudos Nov 22, 2022
50fd058
remove temporal n
krudos Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ARG BUCK_VERSION=2022.05.05.01
# for Buck to pick it up correctly.
ARG NDK_VERSION_BUCK=21.4.7075529
ARG NDK_VERSION_GRADLE=23.1.7779620
ARG NODE_VERSION=14.x
ARG NODE_VERSION=14
ARG WATCHMAN_VERSION=4.9.0
ARG CMAKE_VERSION=3.18.1

Expand Down Expand Up @@ -87,12 +87,10 @@ RUN apt update -qq && apt install -qq -y --no-install-recommends \
&& gem install bundler \
&& rm -rf /var/lib/apt/lists/*;

# install nodejs and yarn packages from nodesource
RUN curl -sL https://deb.nodesource.com/setup_${NODE_VERSION} | bash - \
&& apt-get update -qq \
&& apt-get install -qq -y --no-install-recommends nodejs \
&& npm i -g yarn \
&& rm -rf /var/lib/apt/lists/*
# install nodejs using n
RUN curl -L https://raw.githubusercontent.com/tj/n/master/bin/n -o n \
&& bash n $NODE_VERSION \
&& npm install -g yarn
krudos marked this conversation as resolved.
Show resolved Hide resolved

# download and install buck using the java11 pex from Jitpack
RUN curl -L https://jitpack.io/com/github/facebook/buck/v${BUCK_VERSION}/buck-v${BUCK_VERSION}-java11.pex -o /tmp/buck.pex \
Expand Down