Call init() on delegate from TimedScheduler #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luukveenis Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
|
@luukveenis Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
The TimedScheduler class doesn't currently provide an override for the `init()` method, which means it calls the default implementation on the interface that delegates to `start()`. This works fine for most schedulers, since they have a valid implementation of `start()`. However, the newer BoundedElasticThreadPerTaskScheduler throws an error for `start()`, so wrapping it in a TimedScheduler causes it to crash immediately when `init()` gets called. We should call the wrapped scheduler's `init()` method instead, which allows users to get metrics for their virtual thread schedulers.
luukveenis
force-pushed
the
timed-scheduler-init
branch
from
deebee3
to
ae3998a
Compare
|
@luukveenis Thank you for signing the Contributor License Agreement! |
|
@luukveenis thanks! I took the liberty to add a test to your PR. |
Sorry I meant to add one, thank you! |
chemicL
approved these changes
Aug 22, 2024
chemicL
added a commit
that referenced
this pull request
Aug 22, 2024
|
Thank you for the contribution, @luukveenis 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where wrapping a
BoundedElasticThreadPerTaskSchedulerwithMicrometer#timedScheduler()causes it to error out immediately.The TimedScheduler class doesn't currently override the
init()method, so it calls the default from the interface, which delegates tostart(). This works fine for other scheduler implementations because they still implementstart(), but for the virtual thread scheduler, it simply throws an error. When we wrap it in a timed scheduler, it crashes on this error as soon asinit()gets called.