Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call init() on delegate from TimedScheduler #3876

Merged
merged 2 commits into from
Aug 22, 2024

Commits on Aug 20, 2024

  1. Call init on delegate from TimedScheduler

    The TimedScheduler class doesn't currently provide an override for the
    `init()` method, which means it calls the default implementation on the
    interface that delegates to `start()`. This works fine for most
    schedulers, since they have a valid implementation of `start()`. However,
    the newer BoundedElasticThreadPerTaskScheduler throws an error for
    `start()`, so wrapping it in a TimedScheduler causes it to crash
    immediately when `init()` gets called.
    
    We should call the wrapped scheduler's `init()` method instead, which
    allows users to get metrics for their virtual thread schedulers.
    luukveenis committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ae3998a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    06b61b9 View commit details
    Browse the repository at this point in the history