[CI] Add PHP 8.0 to Github actions tests (#4779)

rectorphp · Dec 5, 2020 · 1e667b4 · 1e667b4
1 parent 34881de
commit 1e667b4
Show file tree

Hide file tree

Showing 27 changed files with 57 additions and 15 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -14,6 +14,9 @@ jobs:
                 include:
                     - php: '7.3'
                       dependencies: 'lowest'
+                    - php: '8.0'
+                      dependencies: 'latest'
+
 
         name: PHP ${{ matrix.php }} tests
         steps:
@@ -28,6 +31,9 @@ jobs:
                 if: "matrix.dependencies == 'lowest'"
 
             -   run: composer install --no-progress --ansi
-                if: "matrix.dependencies != 'lowest'"
+                if: "matrix.dependencies == 'locked'"
+
+            -   run: composer install --no-progress --ansi --ignore-platform-req=php
+                if: "matrix.dependencies == 'latest'"
 
             -   run: vendor/bin/phpunit
diff --git a/...daloneMethodCallRectorTest/InArgChainFluentMethodCallToStandaloneMethodCallRectorTest.php b/...daloneMethodCallRectorTest/InArgChainFluentMethodCallToStandaloneMethodCallRectorTest.php
@@ -13,6 +13,7 @@ final class InArgChainFluentMethodCallToStandaloneMethodCallRectorTest extends A
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/rules/downgrade-php80/src/Rector/ClassConstFetch/DowngradeClassOnObjectToGetClassRector.php b/rules/downgrade-php80/src/Rector/ClassConstFetch/DowngradeClassOnObjectToGetClassRector.php
@@ -63,10 +63,6 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $this->isAtLeastPhpVersion(PhpVersionFeature::CLASS_ON_OBJECT)) {
-            return null;
-        }
-
         if (! $this->isName($node->name, 'class')) {
             return null;
         }

diff --git a/...tch/DowngradeClassOnObjectToGetClassRector/DowngradeClassOnObjectToGetClassRectorTest.php b/...tch/DowngradeClassOnObjectToGetClassRector/DowngradeClassOnObjectToGetClassRectorTest.php
@@ -10,13 +10,11 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
-/**
- * @requires PHP >= 8.0
- */
 final class DowngradeClassOnObjectToGetClassRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP >= 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/...gradeReturnStaticTypeDeclarationRector/DowngradeReturnStaticTypeDeclarationRectorTest.php b/...gradeReturnStaticTypeDeclarationRector/DowngradeReturnStaticTypeDeclarationRectorTest.php
@@ -13,7 +13,7 @@
 final class DowngradeReturnStaticTypeDeclarationRectorTest extends AbstractRectorTestCase
 {
     /**
-     * @requires PHP >= 8.0
+     * @requires PHP = 8.1
      * @dataProvider provideData()
      */
     public function test(SmartFileInfo $fileInfo): void

diff --git a/...DowngradeUnionTypeParamDeclarationRector/DowngradeUnionTypeParamDeclarationRectorTest.php b/...DowngradeUnionTypeParamDeclarationRector/DowngradeUnionTypeParamDeclarationRectorTest.php
@@ -11,7 +11,7 @@
 use Symplify\SmartFileSystem\SmartFileInfo;
 
 /**
- * @requires PHP >= 8.0
+ * @requires PHP 8.1
  */
 final class DowngradeUnionTypeParamDeclarationRectorTest extends AbstractRectorTestCase
 {

diff --git a/...wngradeUnionTypeReturnDeclarationRector/DowngradeUnionTypeReturnDeclarationRectorTest.php b/...wngradeUnionTypeReturnDeclarationRector/DowngradeUnionTypeReturnDeclarationRectorTest.php
@@ -11,7 +11,7 @@
 use Symplify\SmartFileSystem\SmartFileInfo;
 
 /**
- * @requires PHP 8.0
+ * @requires PHP 8.1
  */
 final class DowngradeUnionTypeReturnDeclarationRectorTest extends AbstractRectorTestCase
 {

diff --git a/...perty/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php b/...perty/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php
@@ -11,7 +11,7 @@
 use Symplify\SmartFileSystem\SmartFileInfo;
 
 /**
- * @requires PHP >= 8.0
+ * @requires PHP = 8.1
  */
 final class DowngradeUnionTypeTypedPropertyRectorTest extends AbstractRectorTestCase
 {

diff --git a/.../naming/tests/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector/Php74Test.php b/.../naming/tests/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector/Php74Test.php
@@ -9,10 +9,12 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP = 7.4
+ */
 final class Php74Test extends AbstractRectorTestCase
 {
     /**
-     * @requires PHP 8.0
      * @dataProvider provideData()
      */
     public function test(SmartFileInfo $fileInfo): void

diff --git a/...ToMatchMethodCallReturnTypeRector/RenameVariableToMatchMethodCallReturnTypeRectorTest.php b/...ToMatchMethodCallReturnTypeRector/RenameVariableToMatchMethodCallReturnTypeRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class RenameVariableToMatchMethodCallReturnTypeRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/...aticCallOnNonStaticToInstanceCallRector/StaticCallOnNonStaticToInstanceCallRectorTest.php b/...aticCallOnNonStaticToInstanceCallRector/StaticCallOnNonStaticToInstanceCallRectorTest.php
@@ -13,6 +13,7 @@ final class StaticCallOnNonStaticToInstanceCallRectorTest extends AbstractRector
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/.../tests/Rector/Ternary/TernaryToNullCoalescingRector/TernaryToNullCoalescingRectorTest.php b/.../tests/Rector/Ternary/TernaryToNullCoalescingRector/TernaryToNullCoalescingRectorTest.php
@@ -18,6 +18,7 @@ final class TernaryToNullCoalescingRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/rules/php72/tests/Rector/Assign/ListEachRector/ListEachRectorTest.php b/rules/php72/tests/Rector/Assign/ListEachRector/ListEachRectorTest.php
@@ -18,6 +18,7 @@ final class ListEachRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/...placeEachAssignmentWithKeyCurrentRector/ReplaceEachAssignmentWithKeyCurrentRectorTest.php b/...placeEachAssignmentWithKeyCurrentRector/ReplaceEachAssignmentWithKeyCurrentRectorTest.php
@@ -14,6 +14,7 @@ final class ReplaceEachAssignmentWithKeyCurrentRectorTest extends AbstractRector
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/rules/php72/tests/Rector/ConstFetch/BarewordStringRector/BarewordStringRectorTest.php b/rules/php72/tests/Rector/ConstFetch/BarewordStringRector/BarewordStringRectorTest.php
@@ -13,6 +13,7 @@ final class BarewordStringRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/...l/CreateFunctionToAnonymousFunctionRector/CreateFunctionToAnonymousFunctionRectorTest.php b/...l/CreateFunctionToAnonymousFunctionRector/CreateFunctionToAnonymousFunctionRectorTest.php
@@ -13,6 +13,7 @@ final class CreateFunctionToAnonymousFunctionRectorTest extends AbstractRectorTe
 {
     /**
      * @dataProvider provideData()
+     * @requires PHP < 8.0
      */
     public function test(SmartFileInfo $fileInfo): void
     {

diff --git a/...Rector/FuncCall/ParseStrWithResultArgumentRector/ParseStrWithResultArgumentRectorTest.php b/...Rector/FuncCall/ParseStrWithResultArgumentRector/ParseStrWithResultArgumentRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class ParseStrWithResultArgumentRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/rules/php72/tests/Rector/FuncCall/StringifyDefineRector/StringifyDefineRectorTest.php b/rules/php72/tests/Rector/FuncCall/StringifyDefineRector/StringifyDefineRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class StringifyDefineRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/rules/php72/tests/Rector/FuncCall/StringsAssertNakedRector/StringsAssertNakedRectorTest.php b/rules/php72/tests/Rector/FuncCall/StringsAssertNakedRector/StringsAssertNakedRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class StringsAssertNakedRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/rules/php72/tests/Rector/Unset_/UnsetCastRector/UnsetCastRectorTest.php b/rules/php72/tests/Rector/Unset_/UnsetCastRector/UnsetCastRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP <= 7.2
+ */
 final class UnsetCastRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/rules/php72/tests/Rector/While_/WhileEachToForeachRector/WhileEachToForeachRectorTest.php b/rules/php72/tests/Rector/While_/WhileEachToForeachRector/WhileEachToForeachRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class WhileEachToForeachRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/rules/php74/tests/Rector/Double/RealToFloatTypeCastRector/RealToFloatTypeCastRectorTest.php b/rules/php74/tests/Rector/Double/RealToFloatTypeCastRector/RealToFloatTypeCastRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class RealToFloatTypeCastRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/...sts/Rector/FuncCall/ArrayKeyExistsOnPropertyRector/ArrayKeyExistsOnPropertyRectorTest.php b/...sts/Rector/FuncCall/ArrayKeyExistsOnPropertyRector/ArrayKeyExistsOnPropertyRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class ArrayKeyExistsOnPropertyRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/...p74/tests/Rector/FuncCall/FilterVarToAddSlashesRector/FilterVarToAddSlashesRectorTest.php b/...p74/tests/Rector/FuncCall/FilterVarToAddSlashesRector/FilterVarToAddSlashesRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class FilterVarToAddSlashesRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/.../Rector/MethodCall/RenameMethodRector/Fixture/rename_class_method_and_parent_call.php.inc b/.../Rector/MethodCall/RenameMethodRector/Fixture/rename_class_method_and_parent_call.php.inc
@@ -12,7 +12,7 @@ class MyCustomType extends AbstractType
     }
 }
 
-class AnotherClass
+class AnotherClass extends \DateTime
 {
     public function setDefaultOptions(SomeResolver $resolver)
     {
@@ -36,7 +36,7 @@ class MyCustomType extends AbstractType
     }
 }
 
-class AnotherClass
+class AnotherClass extends \DateTime
 {
     public function setDefaultOptions(SomeResolver $resolver)
     {

diff --git a/rules/symfony/tests/Rector/StaticCall/ParseFileRector/ParseFileRectorTest.php b/rules/symfony/tests/Rector/StaticCall/ParseFileRector/ParseFileRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class ParseFileRectorTest extends AbstractRectorTestCase
 {
     /**

diff --git a/...Rector/Property/CompleteVarDocTypePropertyRector/CompleteVarDocTypePropertyRectorTest.php b/...Rector/Property/CompleteVarDocTypePropertyRector/CompleteVarDocTypePropertyRectorTest.php
@@ -9,6 +9,9 @@
 use Rector\TypeDeclaration\Rector\Property\CompleteVarDocTypePropertyRector;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
+/**
+ * @requires PHP < 8.0
+ */
 final class CompleteVarDocTypePropertyRectorTest extends AbstractRectorTestCase
 {
     /**