[CI] Add PHP 8.0 to Github actions tests #4779

samsonasik · 2020-12-04T14:16:23Z

No description provided.

samsonasik · 2020-12-04T15:00:26Z

Got php 8 downgrade errors:

Downgrade Class On Object To Get Class Rector (Rector\DowngradePhp80\Tests\Rector\ClassConstFetch\DowngradeClassOnObjectToGetClassRector\DowngradeClassOnObjectToGetClassRector)
 ✘  with data set #0
   │
   │ rules/downgrade-php80/tests/Rector/ClassConstFetch/DowngradeClassOnObjectToGetClassRector/Fixture/fixture.php.inc
   │ Failed asserting that string matches format description.
   │ --- Expected
   │ +++ Actual
   │ @@ @@
   │  {
   │      public function run($object)
   │      {
   │ -        return get_class($object);
   │ +        return $object::class;
   │      }
   │  }
   │
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:486
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:308
   │ /home/runner/work/rector/rector/rules/downgrade-php80/tests/Rector/ClassConstFetch/DowngradeClassOnObjectToGetClassRector/DowngradeClassOnObjectToGetClassRectorTest.php:21
   │


Downgrade Return Static Type Declaration Rector (Rector\DowngradePhp80\Tests\Rector\FunctionLike\DowngradeReturnStaticTypeDeclarationRector\DowngradeReturnStaticTypeDeclarationRector)
 ✘  with data set #0
   │
   │ rules/downgrade-php80/tests/Rector/FunctionLike/DowngradeReturnStaticTypeDeclarationRector/Fixture/fixture.php.inc
   │ /home/runner/work/rector/rector/src/Application/FileProcessor.php:143
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:439
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:308
   │ /home/runner/work/rector/rector/rules/downgrade-php80/tests/Rector/FunctionLike/DowngradeUnionTypeReturnDeclarationRector/DowngradeUnionTypeReturnDeclarationRectorTest.php:23
   │

Downgrade Union Type Typed Property Rector (Rector\DowngradePhp80\Tests\Rector\Property\DowngradeUnionTypeTypedPropertyRector\DowngradeUnionTypeTypedPropertyRector)
 ✘  with data set #0
   │
   │ Rector\Core\Exception\NotImplementedException: PhpParser\Node\UnionType
   │
   │ /home/runner/work/rector/rector/packages/static-type-mapper/src/Mapper/PhpParserNodeMapper.php:45
   │ /home/runner/work/rector/rector/packages/static-type-mapper/src/StaticTypeMapper.php:82
   │ /home/runner/work/rector/rector/rules/downgrade-php74/src/Rector/Property/AbstractDowngradeTypedPropertyRector.php:45
   │ /home/runner/work/rector/rector/src/Rector/AbstractRector.php:231
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:200
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
   │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91
   │ /home/runner/work/rector/rector/src/PhpParser/NodeTraverser/RectorNodeTraverser.php:119
   │ /home/runner/work/rector/rector/src/Application/FileProcessor.php:143
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:439
   │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:308
   │ /home/runner/work/rector/rector/rules/downgrade-php80/tests/Rector/Property/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php:2

samsonasik · 2020-12-04T15:35:18Z

@TomasVotruba It seems isAtLeastPhpVersion() not works for php 8, debug with the following:

        dump(
            PHP_VERSION,
            $this->isAtLeastPhpVersion(PhpVersionFeature::CLASS_ON_OBJECT)
        );

got:

"8.0.0" (5)
false

samsonasik · 2020-12-04T15:41:31Z

It seems because of test definition:

    protected function getPhpVersion(): int
    {
        return PhpVersionFeature::CLASS_ON_OBJECT - 1;
    }

samsonasik · 2020-12-04T16:09:10Z

Got weird error at Rector\Naming\Tests\Rector\Assign\RenameVariableToMatchMethodCallReturnTypeRector\Php74Test

Php74 (Rector\Naming\Tests\Rector\Assign\RenameVariableToMatchMethodCallReturnTypeRector\Php74)
 ✘  with data set #0
   │
   │ rules/naming/tests/Rector/Assign/RenameVariableToMatchMethodCallReturnTypeRector/FixturePhp74/arrow_function.php.inc
   │ Failed asserting that string matches format description.
   │ --- Expected
   │ +++ Actual
   │ @@ @@
   │      {
   │          $datetime = new DateTime();
   │  
   │ -        $fn1 = fn($x) => $x + $dateTimeZone = $datetime->getTimezone();
   │ +        $fn1 = fn($x) => $x + $timezone = $datetime->getTimezone();
   │      }
   │  }

samsonasik · 2020-12-04T16:46:51Z

More error in test in php 8 :

To String To Method Call Rector (Rector\MagicDisclosure\Tests\Rector\String_\ToStringToMethodCallRector\ToStringToMethodCallRector)
 ✔  with data set #0
PHP Fatal error:  Cannot use "parent" when current class scope has no parent in /tmp/_temp_fixture_easy_testing/input_d61e4d22d14036671bb8_rename_class_method_and_parent_call.php on line 19

seems need to be fixed in somewhere in the code instead

…ector

samsonasik · 2020-12-05T03:09:07Z

...owngradeReturnStaticTypeDeclarationRector/DowngradeReturnStaticTypeDeclarationRectorTest.php

@@ -13,7 +13,7 @@
 final class DowngradeReturnStaticTypeDeclarationRectorTest extends AbstractRectorTestCase
 {
    /**
-     * @requires PHP >= 8.0
+     * @requires PHP >= 9.0


@TomasVotruba I set temporary this as test is not working:

Downgrade Union Type Typed Property Rector (Rector\DowngradePhp80\Tests\Rector\Property\DowngradeUnionTypeTypedPropertyRector\DowngradeUnionTypeTypedPropertyRector) ✘ with data set #0 │ │ Rector\Core\Exception\NotImplementedException: PhpParser\Node\UnionType │ │ /home/runner/work/rector/rector/packages/static-type-mapper/src/Mapper/PhpParserNodeMapper.php:45 │ /home/runner/work/rector/rector/packages/static-type-mapper/src/StaticTypeMapper.php:82 │ /home/runner/work/rector/rector/rules/downgrade-php74/src/Rector/Property/AbstractDowngradeTypedPropertyRector.php:45 │ /home/runner/work/rector/rector/src/Rector/AbstractRector.php:231 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:200 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223 │ /home/runner/work/rector/rector/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91 │ /home/runner/work/rector/rector/src/PhpParser/NodeTraverser/RectorNodeTraverser.php:119 │ /home/runner/work/rector/rector/src/Application/FileProcessor.php:143 │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:439 │ /home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:308 │ /home/runner/work/rector/rector/rules/downgrade-php80/tests/Rector/Property/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php:23

marked to 8.1 seems works, this is temporary to be fixed in the future.

samsonasik · 2020-12-05T03:28:35Z

All checks have passed 🎉 @TomasVotruba it is ready for review.

...Property/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php

TomasVotruba · 2020-12-05T10:12:45Z

@TomasVotruba It seems isAtLeastPhpVersion() not works for php 8, debug with the following:
        dump(
            PHP_VERSION,
            $this->isAtLeastPhpVersion(PhpVersionFeature::CLASS_ON_OBJECT)
        );
got:
"8.0.0" (5)
false

Instead of PHP_VERSION, it should be PHP_VERSION_ID

TomasVotruba · 2020-12-05T11:10:40Z

Let's go :)

TomasVotruba · 2020-12-06T00:55:08Z

Most of the skipped test cases are fixed here:
#4805

samsonasik · 2020-12-06T00:57:44Z

Thank you

rectorphp/rector-src@2970fa1 [TypeDeclaration] Skip in conditional on AddParamTypeFromPropertyTypeRector (#4779)

samsonasik force-pushed the php8 branch from a7607ef to 074c821 Compare December 4, 2020 15:11

samsonasik force-pushed the php8 branch from 1ae2069 to bffc6ce Compare December 4, 2020 15:43

samsonasik added 23 commits December 5, 2020 09:37

[CI] Add PHP 8.0 to Github actions tests

cc6222a

using --ignore-platform-req=php for php 8

a40578f

using --ignore-platform-req in not lowest

627567c

use testdox="true" to know what file cause error in test

899dfa2

use @requires PHP < 8.0 for code not compatible with php 8

a468a53

use @requires PHP < 8.0 for code not compatible with php 8

4f9804b

use @requires PHP < 8.0 for code not compatible with php 8

a292710

use in tests @requires

545e153

use @requires PHP < 8.0 for code not compatible with php 8

635d954

class based @requires PHP < 8.0

8582801

use @requires PHP < 8.0 for code not compatible with php 8

240bf5a

class based @requires PHP < 8.0

a47f85d

use @requires PHP < 8.0 for code not compatible with php 8

9bca4d5

class based @requires PHP < 8.0

b27ea85

debug

5d97838

use 3 dif env

5e21bda

debug

c44f633

debug

832d73e

debug

683d6d0

debug

c4d5f4d

retry

a78b3d7

retry

cd69f55

Php74Test requires fix for RenameVariableToMatchMethodCallReturnTypeR…

a52aaf4

…ector

samsonasik added 7 commits December 5, 2020 09:39

class based @requires PHP 7.4

d2e335b

retry

fdb8476

check unset

393141e

check unset

f5932ea

check php 7.4

3accafb

check php 7.4

018e111

try @requires PHP = 7.4

86ea558

samsonasik force-pushed the php8 branch from b8b2c1e to c81251b Compare December 5, 2020 02:39

php 8 syntax compat

7e6e6db

samsonasik force-pushed the php8 branch from c81251b to 7e6e6db Compare December 5, 2020 02:58

temporary set @requires PHP >= 9.0 for not working test

16defaa

samsonasik commented Dec 5, 2020

View reviewed changes

samsonasik added 4 commits December 5, 2020 10:11

8.1 for temporary

1171ec5

8.1 for temporary

cccca25

8.1 for temporary

9841113

remove testdox

49ff64a

TomasVotruba reviewed Dec 5, 2020

View reviewed changes

...Property/DowngradeUnionTypeTypedPropertyRector/DowngradeUnionTypeTypedPropertyRectorTest.php Show resolved Hide resolved

TomasVotruba merged commit 1e667b4 into master Dec 5, 2020

TomasVotruba deleted the php8 branch December 5, 2020 11:10

This was referenced Dec 5, 2020

[WIP] Allow to use PHP 8.0 #4146

Closed

[CI] Add PHP 8.0 run for Rector #4145

Closed

TomasVotruba mentioned this pull request Dec 6, 2020

[PHP 8.0] CI test fixes #4805

Merged

TomasVotruba added a commit that referenced this pull request Aug 13, 2023

Updated Rector to commit 2970fa114ef632768f4704c8eefd2f5d0310703c

5034b0a

rectorphp/rector-src@2970fa1 [TypeDeclaration] Skip in conditional on AddParamTypeFromPropertyTypeRector (#4779)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Add PHP 8.0 to Github actions tests #4779

[CI] Add PHP 8.0 to Github actions tests #4779

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik Dec 5, 2020

samsonasik Dec 5, 2020

samsonasik commented Dec 5, 2020

TomasVotruba commented Dec 5, 2020

TomasVotruba commented Dec 5, 2020

TomasVotruba commented Dec 6, 2020

samsonasik commented Dec 6, 2020

[CI] Add PHP 8.0 to Github actions tests #4779

[CI] Add PHP 8.0 to Github actions tests #4779

Conversation

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik commented Dec 4, 2020

samsonasik Dec 5, 2020

Choose a reason for hiding this comment

samsonasik Dec 5, 2020

Choose a reason for hiding this comment

samsonasik commented Dec 5, 2020

TomasVotruba commented Dec 5, 2020

TomasVotruba commented Dec 5, 2020

TomasVotruba commented Dec 6, 2020

samsonasik commented Dec 6, 2020