Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a way to set website properties #590

Closed
2 tasks
damithc opened this issue Mar 7, 2019 · 4 comments · Fixed by #1343
Closed
2 tasks

Give a way to set website properties #590

damithc opened this issue Mar 7, 2019 · 4 comments · Fixed by #1343
Assignees
@Boon-Jun
Labels
c.Feature p.Low

Comments

@damithc
Copy link
Collaborator

damithc commented Mar 7, 2019 •
edited by Boon-Jun
Loading

Current:
The deployed dashboard doesn't have a name, favicon, etc.
image

Suggestion: Give a way to specify such website properties.

Items to do:

  • A way to set favicon
  • A way to set page title
@fzdy1914 fzdy1914 mentioned this issue Mar 19, 2019
Merged
yamidark pushed a commit that referenced this issue Mar 20, 2019
@fzdy1914 @yamidark
[#590] Add default title and icon for RepoSense (#612)
df71dc3 
We do not have a title and icon set for the generated report.

This causes the title to be automatically set to the url of the page
instead, which does not provide any useful information to the user.

Let's add a default title and icon for the generated report.
@fzdy1914
Copy link
Member

Related to #467. I am considering to add a new config in our codebase with serves the role to configure the generated report. Including title, icon, intro or anything else which may need in the future to configure the report.

@damithc
Copy link
Collaborator Author

damithc commented Mar 25, 2019

Related to #467. I am considering to add a new config in our codebase with serves the role to configure the generated report. Including title, icon, intro or anything else which may need in the future to configure the report.

Good idea. Note that a config file not may be the best format to hold HTML content, to be used in the intro, unless you restrict the intro to plain text only. The alternative is to expect these info to be in a specific files e.g., /site_config/favicon.ico /site_config/intro.html etc.

@fzdy1914 fzdy1914 mentioned this issue Mar 25, 2019
Closed
@Tejas2805 Tejas2805 mentioned this issue Sep 22, 2019
Merged
@Tejas2805
Copy link
Contributor

@damithc What else do we have left for this? Anything else left or can we close this?

@damithc
Copy link
Collaborator Author

damithc commented Dec 28, 2019

@damithc What else do we have left for this? Anything else left or can we close this?

I updated issue description to add the required tasks

@Boon-Jun Boon-Jun mentioned this issue Oct 18, 2020
Merged
@Boon-Jun Boon-Jun self-assigned this Oct 18, 2020
fzdy1914 pushed a commit that referenced this issue Nov 15, 2020
@Boon-Jun
[#590] Configuring report generation (#1343)
d926f69 
The generated report does not allow the customization of some 
website properties such as page title and favicons.

Let's add a new model `ReportConfiguration` that allows 
customization of page titles via a json config file. Report 
Generation also takes an assets folder location into consideration 
for the customization of favicons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boon-Jun Boon-Jun

Labels
c.Feature p.Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#590] Configuring report generation Boon-Jun/RepoSense
5 participants
@damithc @jamessspanggg @Boon-Jun @fzdy1914 @Tejas2805