Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#897] Report: favicon not showing on github pages #898

Merged
merged 6 commits into from
Sep 30, 2019

Conversation

Tejas2805
Copy link
Contributor

@Tejas2805 Tejas2805 commented Sep 22, 2019

Fixes #897

Modern browsers automatically try to load the favicon from the root of
the website.

However, for GitHub pages, our favicon is not located in the root but in
another path.

Let's explicitly add a link to our favicon resource so that it gets
displayed. 

@yong24s
Copy link
Contributor

yong24s commented Sep 22, 2019

@Tejas2805
You want to change your commit message so that this PR directly address #897?

@Tejas2805
Copy link
Contributor Author

Tejas2805 commented Sep 22, 2019

@yong24s I came across the PR #612 last night and saw that icon wasn't added though it said that it did, so worked on it from that POV. Didn't see your issue. Do you think I should close the PR, so that the first-timers can still have a try at this?

@yong24s
Copy link
Contributor

yong24s commented Sep 23, 2019

@Tejas2805

Since you already worked on it, it's fine (also its fine by me if you worked on a few first timer issues, when you are starting out). You can help to dogfood and create more first timer issues :).

Copy link
Contributor

@yong24s yong24s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tejas2805

#612 did add the favicon but it didn't work when the favicon is not in the root url.
Read #897 and write a commit message that addresses to it.

I already tested your patch and it fixes the issue.

@Tejas2805 Tejas2805 changed the title Add default icon to generated report [#897]Add default icon to generated report Sep 23, 2019
@yong24s yong24s changed the title [#897]Add default icon to generated report [#897] Report: favicon not showing on github pages Sep 30, 2019
@yong24s yong24s merged commit 0572af7 into reposense:master Sep 30, 2019
@Tejas2805 Tejas2805 deleted the Add-icon-to-website-properties branch October 4, 2019 16:37
@Tejas2805 Tejas2805 restored the Add-icon-to-website-properties branch October 4, 2019 16:44
@Tejas2805 Tejas2805 deleted the Add-icon-to-website-properties branch October 4, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report: favicon not showing on github pages
2 participants