Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: favicon not showing on github pages #897

Closed
yong24s opened this issue Sep 21, 2019 · 0 comments · Fixed by #898
Closed

Report: favicon not showing on github pages #897

yong24s opened this issue Sep 21, 2019 · 0 comments · Fixed by #898
Labels
d.FirstTimers

Comments

@yong24s
Copy link
Contributor

yong24s commented Sep 21, 2019

Modern browsers automatically try to load the favicon from the root of the website. i.e. https://reposense.netlify.com/favicon.ico

However, for GitHub pages i.e. https://nus-cs2103-ay1920s1.github.io/tp-dashboard/favicon.ico, the favicon is not located in the root but in another path.

Let's explicitly use a link it to the actual favicon.ico resource. i.e. <link rel="shortcut icon" href="favicon.ico" />
@yong24s yong24s mentioned this issue Sep 22, 2019
Merged
yong24s pushed a commit that referenced this issue Sep 30, 2019
@Tejas2805 @yong24s
[#897] Report: favicon not showing on github pages (#898)
0572af7 
Modern browsers automatically try to load the favicon from the root of
the website.

However, for GitHub pages, our favicon is not located in the root but in
another path.

Let's explicitly add a link to our favicon resource so that it gets
displayed.
@SunburstEnzo SunburstEnzo mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d.FirstTimers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#897] Report: favicon not showing on github pages Tejas2805/RepoSense
1 participant
@yong24s