Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some crates sources to "rust-src" distribution. #58268

Closed
taeguk opened this issue Feb 7, 2019 · 3 comments
Closed

Add some crates sources to "rust-src" distribution. #58268

taeguk opened this issue Feb 7, 2019 · 3 comments

Comments

@taeguk
Copy link
Contributor

taeguk commented Feb 7, 2019

In IntelliJ-Rust and rls-vscode, rust-src component is used to acquire standard crates sources.
But, in currently, librustc, librustc_plugin, and libsyntax are emitted in the list below.

let std_src_dirs = [

So, syntax highlighting and code completion are not working when using those crates in IntelliJ-Rust or rls-vscode.

There was similar issue #55279 about libproc_macro and it was fixed in #55280.
How about adding those crates (librustc, librustc_plugin, and libsyntax) to the list above, too?

Related issue: intellij-rust/intellij-rust#2623

@ishitatsuyuki
Copy link
Contributor

Related: #42667

bors added a commit that referenced this issue Mar 5, 2019
…on, r=Mark-Simulacrum

Add librustc and libsyntax to rust-src distribution.

Fixes #58268.
pietroalbini added a commit to pietroalbini/rust that referenced this issue Mar 8, 2019
…-distribution, r=Mark-Simulacrum

Add librustc and libsyntax to rust-src distribution.

Fixes rust-lang#58268.
@eddyb
Copy link
Member

eddyb commented Mar 2, 2020

Is this still a concern? I don't think the current set of crates (librustc and librustc_ast) are enough to cover plugin dependencies anymore but I don't think we've heard back from anyone about it.

IMO the solution used here (to add compiler crates to rust-src) is not ideal, and we should probably have any compiler sources available through a different rustup component, if we actually need them.

For now we should probably just remove librustc and librustc_ast from the list.

cc @Mark-Simulacrum

@RalfJung
Copy link
Member

RalfJung commented Mar 2, 2020

Also see #69631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants