Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add librustc and libsyntax to rust-src distribution. #58269

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Add librustc and libsyntax to rust-src distribution. #58269

merged 1 commit into from
Mar 9, 2019

Conversation

taeguk
Copy link
Contributor

@taeguk taeguk commented Feb 7, 2019

Fixes #58268.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 7, 2019

cc @rust-lang/compiler

@eddyb has concerns about including the plugin crate

@Centril
Copy link
Contributor

Centril commented Feb 8, 2019

It doesn't seem like a good idea to facilitate using librustc_plugin more in user-space.

@Centril
Copy link
Contributor

Centril commented Feb 8, 2019

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned alexcrichton Feb 8, 2019
@eddyb
Copy link
Member

eddyb commented Feb 13, 2019

Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2019
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Ping from triage, @taeguk, what are your thoughts re. the question above?

@taeguk
Copy link
Contributor Author

taeguk commented Feb 24, 2019 •
edited
Loading

@Centril @eddyb When developing a compiler plugin, librustc_plugin is used. So, adding librustc_plugin to rust-src distribution is needed for auto completion in IDE. This is just my short humble thought.

@oli-obk
Copy link
Contributor

oli-obk commented Feb 25, 2019

We don't want anyone to actually keep developing plugins. We want to get rid of them entirely. Including them in this list sends the wrong message imo.

@taeguk
Copy link
Contributor Author

taeguk commented Feb 25, 2019 •
edited
Loading

@oli-obk if so, librustc_plugin should not be added to rust-src in my opinion, too.

@aleksmelnikov
Copy link

@oli-obk , is a compiler plugin deprecated api?

@oli-obk
Copy link
Contributor

oli-obk commented Feb 26, 2019

is a compiler plugin deprecated api?

Not yet, but I want to make it so, since we do have replacement APIs that are stable or in the process of being stabilized.

@petrochenkov
Copy link
Contributor

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

r=me with rustc_plugin removed.

@taeguk taeguk force-pushed the add-some-sources-to-rust-src-distribution branch from 2cc5b45 to cbe3344 Compare March 4, 2019 23:58
@taeguk taeguk changed the title Add librustc, librustc_plugin, and libsyntax to rust-src distribution. Add librustc and libsyntax to rust-src distribution. Mar 4, 2019
@taeguk
Copy link
Contributor Author

taeguk commented Mar 4, 2019

I removed librustc_plugin.

@estebank
Copy link
Contributor

estebank commented Mar 5, 2019

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 5, 2019

📌 Commit cbe3344 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2019
@bors
Copy link
Contributor

bors commented Mar 5, 2019

⌛ Testing commit cbe3344 with merge f837c455c4f1de0ba1667054a5be230129b9dcec...

@bors
Copy link
Contributor

bors commented Mar 5, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2019
@ljedrz
Copy link
Contributor

ljedrz commented Mar 5, 2019 

Build completed successfully in 3:05:50
Command exited with code 259

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2019
@bors
Copy link
Contributor

bors commented Mar 5, 2019

⌛ Testing commit cbe3344 with merge 4e8181c...

bors added a commit that referenced this pull request Mar 5, 2019
@bors
Auto merge of #58269 - taeguk:add-some-sources-to-rust-src-distributi…
4e8181c 
…on, r=Mark-Simulacrum

Add librustc and libsyntax to rust-src distribution.

Fixes #58268.
@bors
Copy link
Contributor

bors commented Mar 5, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2019
@ljedrz
Copy link
Contributor

ljedrz commented Mar 5, 2019

The same error on a previously green machine.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 6, 2019

@bors rollup

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 8, 2019
@pietroalbini
Rollup merge of rust-lang#58269 - taeguk:add-some-sources-to-rust-src…
bf7b502 
…-distribution, r=Mark-Simulacrum

Add librustc and libsyntax to rust-src distribution.

Fixes rust-lang#58268.
@pietroalbini pietroalbini mentioned this pull request Mar 8, 2019
Merged
bors added a commit that referenced this pull request Mar 9, 2019
@bors
Auto merge of #59012 - pietroalbini:rollup, r=pietroalbini
c9f8304 
Rollup of 24 pull requests

Successful merges:

 - #58080 (Add FreeBSD armv6 and armv7 targets)
 - #58204 (On return type `impl Trait` for block with no expr point at last semi)
 - #58269 (Add librustc and libsyntax to rust-src distribution.)
 - #58369 (Make the Entry API of HashMap<K, V> Sync and Send)
 - #58861 (Expand where negative supertrait specific error is shown)
 - #58877 (Suggest removal of `&` when borrowing macro and appropriate)
 - #58883 (Suggest appropriate code for unused field when destructuring pattern)
 - #58891 (Remove stray ` in the docs for the FromIterator implementation for Option)
 - #58893 (race condition in thread local storage example)
 - #58906 (Monomorphize generator field types for debuginfo)
 - #58911 (Regression test for #58435.)
 - #58912 (Regression test for #58813)
 - #58916 (Fix release note problems noticed after merging.)
 - #58918 (Regression test added for an async ICE.)
 - #58921 (Add an explicit test for issue #50582)
 - #58926 (Make the lifetime parameters of tcx consistent.)
 - #58931 (Elide invalid method receiver error when it contains TyErr)
 - #58940 (Remove JSBackend from config.toml)
 - #58950 (Add self to mailmap)
 - #58961 (On incorrect cfg literal/identifier, point at the right span)
 - #58963 (libstd: implement Error::source for io::Error)
 - #58970 (delay_span_bug in wfcheck's ty.lift_to_tcx unwrap)
 - #58984 (Teach `-Z treat-err-as-bug` to take a number of errors to emit)
 - #59007 (Add a test for invalid const arguments)

Failed merges:

 - #58959 (Add release notes for PR #56243)

r? @ghost
@bors bors merged commit cbe3344 into rust-lang:master Mar 9, 2019
@oli-obk oli-obk mentioned this pull request Mar 18, 2019
Closed
This was referenced Mar 2, 2020
Merged
Merged
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
@Centril
Rollup merge of rust-lang#69631 - RalfJung:rust-src, r=Mark-Simulacrum
efad0cb 
remove non-sysroot sources from rust-src component

See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources.

OTOH, @eddyb [wrote](rust-lang#58269 (comment))

> Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

So maybe there is some good reason to keep these? Then we should have a comment explaining that reason.

Cc @eddyb @taeguk @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
@Centril
Rollup merge of rust-lang#69631 - RalfJung:rust-src, r=Mark-Simulacrum
b3c405c 
remove non-sysroot sources from rust-src component

See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources.

OTOH, @eddyb [wrote](rust-lang#58269 (comment))

> Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

So maybe there is some good reason to keep these? Then we should have a comment explaining that reason.

Cc @eddyb @taeguk @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.