Rollup of 6 pull requests #101452
Closed
Rollup of 6 pull requests #101452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op order The drop order of let and let else is supposed to be the same, and in order to ensure this, the test checks that this holds for the given list of cases. The test also ensures that we drop the temporaries of the condition before executing the else block. We made the test matrix based so it can check all the possible combinations and find out possible edge cases.
Add let else drop order tests Add a systematic matrix based test that checks temporary drop order in various settings, `let-else-drop-order.rs`, as requested [here](rust-lang#93628 (comment)). The drop order of let and let else is supposed to be the and in order to ensure this, the test checks that this holds for a number of cases. The test also ensures that we drop the temporaries of the condition before executing the else block. cc rust-lang#87335 tracking issue for `let else`
…r=lcnr TyCtxt::get_attr should check that no duplicates are allowed Fixes rust-lang#100631
…=cjgillot Suggest removing unnecessary prefix let in patterns Helps with rust-lang#101291, though I think `@estebank` probably wants this: > Finally, I think it'd be nice if we could detect that we don't know for sure and "just" swallow the rest of the expression (find the next ; accounting for nested braces) or the end of the item (easier). ... to be implemented before we close that issue out completely.
…shtriplett Fix cleanup for uninitialized stdout Fixes rust-lang#101375 by disabling buffering even if the buffer was not initialized yet.
…mention-r-a, r=Mark-Simulacrum Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed" Reverts rust-lang#99183 rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
… r=spastorino Point at type parameter in plain path expr Slightly better error message for a kinda unique use case.
rustbot
added
A-translation
|
@bors r+ rollup=never p=6 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 8f6acb0 with merge 5209398166214ab7271e87816b03bf91678a6866... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
davidtwco
removed
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
proc_macrobridge is changed" #101418 (Revert "Mention rust-analyzer maintainers whenproc_macrobridge is changed")Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup