Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #101452

Closed
wants to merge 12 commits into from

Commits on Aug 21, 2022

  1. Configuration menu
    Copy the full SHA
    7d45a75 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Configuration menu
    Copy the full SHA
    91674cc View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Configuration menu
    Copy the full SHA
    f5cd223 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b3c706 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Configuration menu
    Copy the full SHA
    774cadf View commit details
    Browse the repository at this point in the history
  2. Add matrix based test for documenting the let / let else temporary dr…

    …op order
    
    The drop order of let and let else is supposed to be the same,
    and in order to ensure this, the test checks that this holds for
    the given list of cases.
    
    The test also ensures that we drop the temporaries of the
    condition before executing the else block.
    
    We made the test matrix based so it can check all the possible
    combinations and find out possible edge cases.
    est31 committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2d8460e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#99291 - est31:let_else_tests, r=joshtriplett

    Add let else drop order tests
    
    Add a systematic matrix based test that checks temporary drop order in various settings, `let-else-drop-order.rs`, as requested [here](rust-lang#93628 (comment)).
    
    The drop order of let and let else is supposed to be the and in order to ensure this, the test checks that this holds for a number of cases.
    
    The test also ensures that we drop the temporaries of the condition before executing the else block.
    
    cc rust-lang#87335 tracking issue for `let else`
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f9709a7 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#100658 - chenyukang:100631-check-get-attr, …

    …r=lcnr
    
    TyCtxt::get_attr should check that no duplicates are allowed
    
    Fixes rust-lang#100631
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    96704a6 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#101362 - compiler-errors:unnecessary-let, r…

    …=cjgillot
    
    Suggest removing unnecessary prefix let in patterns
    
    Helps with rust-lang#101291, though I think `@estebank` probably wants this:
    
    > Finally, I think it'd be nice if we could detect that we don't know for sure and "just" swallow the rest of the expression (find the next ; accounting for nested braces) or the end of the item (easier).
    
    ... to be implemented before we close that issue out completely.
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    42770d1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#101404 - joboet:always_cleanup_stdout, r=jo…

    …shtriplett
    
    Fix cleanup for uninitialized stdout
    
    Fixes rust-lang#101375 by disabling buffering even if the buffer was not initialized yet.
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6653d70 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#101418 - rust-lang:revert-99183-proc_macro-…

    …mention-r-a, r=Mark-Simulacrum
    
    Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed"
    
    Reverts rust-lang#99183
    
    rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c95bb36 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#101425 - compiler-errors:point-at-ty-param,…

    … r=spastorino
    
    Point at type parameter in plain path expr
    
    Slightly better error message for a kinda unique use case.
    matthiaskrgr authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8f6acb0 View commit details
    Browse the repository at this point in the history