Recover from using ; as separator between fields
#101457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
struct-field-semi
branch
from
2dba6a0
to
fbf11cf
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2022
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#101357 (Include enum path in variant suggestion) - rust-lang#101434 (Update `SessionDiagnostic::into_diagnostic` to take `Handler` instead of `ParseSess`) - rust-lang#101445 (Suggest introducing an explicit lifetime if it does not exist) - rust-lang#101457 (Recover from using `;` as separator between fields) - rust-lang#101462 (Rustdoc-Json: Store Variant Fields as their own item.) - rust-lang#101471 (Report number of delayed bugs properly with `-Ztreat-err-as-bug`) - rust-lang#101473 (Add more size assertions for MIR types.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Rustc gets better and better |
estebank
reviewed
Sep 15, 2022
| ",", | ||
| Applicability::MachineApplicable, | ||
| ); | ||
| return Err(err); |
There was a problem hiding this comment.
Ideally this would have recovered as if a , had been found (emitting this error instead of returning it and calling self.bump())...
estebank
reviewed
Sep 15, 2022
Comment on lines
+19
to
+26
| error: unions cannot have zero fields | ||
| --> $DIR/recover-field-semi.rs:6:1 | ||
| | | ||
| LL | / union Bar { | ||
| LL | | foo: i32; | ||
| LL | | | ||
| LL | | } | ||
| | |_^ |
There was a problem hiding this comment.
Which would have caused this error to not be emitted (and other uses not to complain about a missing foo field).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #101440 (only for record structs).
Doing that for tuple structs is harder as their parsing passes through a bunch of helper functions. I don't know how to do that. But their error message is better anyway and suggests using a comma, even if it doesn't suggest replacing the semicolon with it.