Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from using ; as separator between fields #101457

Merged
merged 1 commit into from
Sep 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions compiler/rustc_parse/src/parser/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,17 @@ impl<'a> Parser<'a> {
if self.token == token::Comma {
seen_comma = true;
}
if self.eat(&token::Semi) {
let sp = self.prev_token.span;
let mut err = self.struct_span_err(sp, format!("{adt_ty} fields are separated by `,`"));
err.span_suggestion_short(
sp,
"replace `;` with `,`",
",",
Applicability::MachineApplicable,
);
return Err(err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would have recovered as if a , had been found (emitting this error instead of returning it and calling self.bump())...

}
match self.token.kind {
token::Comma => {
self.bump();
Expand Down
16 changes: 16 additions & 0 deletions src/test/ui/parser/recover-field-semi.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
struct Foo {
foo: i32;
//~^ ERROR struct fields are separated by `,`
}

union Bar { //~ ERROR
foo: i32;
//~^ ERROR union fields are separated by `,`
}

enum Baz {
Qux { foo: i32; }
//~^ ERROR struct fields are separated by `,`
}

fn main() {}
29 changes: 29 additions & 0 deletions src/test/ui/parser/recover-field-semi.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
error: struct fields are separated by `,`
--> $DIR/recover-field-semi.rs:2:13
|
LL | foo: i32;
| ^ help: replace `;` with `,`

error: union fields are separated by `,`
--> $DIR/recover-field-semi.rs:7:13
|
LL | foo: i32;
| ^ help: replace `;` with `,`

error: struct fields are separated by `,`
--> $DIR/recover-field-semi.rs:12:19
|
LL | Qux { foo: i32; }
| ^ help: replace `;` with `,`

error: unions cannot have zero fields
--> $DIR/recover-field-semi.rs:6:1
|
LL | / union Bar {
LL | | foo: i32;
LL | |
LL | | }
| |_^
Comment on lines +19 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which would have caused this error to not be emitted (and other uses not to complain about a missing foo field).


error: aborting due to 4 previous errors

2 changes: 1 addition & 1 deletion src/test/ui/parser/removed-syntax-field-semicolon.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
struct S {
bar: ();
//~^ ERROR expected `,`, or `}`, found `;`
//~^ ERROR struct fields are separated by `,`
}

fn main() {}
4 changes: 2 additions & 2 deletions src/test/ui/parser/removed-syntax-field-semicolon.stderr
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
error: expected `,`, or `}`, found `;`
error: struct fields are separated by `,`
--> $DIR/removed-syntax-field-semicolon.rs:2:12
|
LL | bar: ();
| ^
| ^ help: replace `;` with `,`

error: aborting due to previous error