rustdoc: CSS prevent sidebar width change jank #102146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/sidebar-jank
branch
from
28f15a1
to
0ef3587
Compare
GuillaumeGomez
approved these changes
Sep 22, 2022
|
And you did it by the time I finished writing this comment. :) Thanks a lot for this fix! I had it into my backlog since a while. r=me once CI pass |
notriddle
force-pushed
the
notriddle/sidebar-jank
branch
from
0ef3587
to
748fc84
Compare
GuillaumeGomez
approved these changes
Sep 22, 2022
notriddle
commented
Sep 22, 2022
notriddle
force-pushed
the
notriddle/sidebar-jank
branch
from
748fc84
to
58bd815
Compare
notriddle
force-pushed
the
notriddle/sidebar-jank
branch
from
58bd815
to
746edb2
Compare
notriddle
force-pushed
the
notriddle/sidebar-jank
branch
from
746edb2
to
cd48154
Compare
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 23, 2022
…r=GuillaumeGomez rustdoc: CSS prevent sidebar width change jank This commit makes the `width` and `min-width` of the sidebar the same. They originally were when cad0fce added the `min-width` rule, but 6a5f8b1 changed the `width` without changing the `min-width`, causing it to sometimes oscilate between 200 and 250 pixels depending on the main content. # Before [Screencast from 09-22-2022 10:25:29 AM.webm](https://user-images.githubusercontent.com/1593513/191813469-ea00f30f-6f49-40fc-9a26-e1dfd5068d2b.webm) # After [Screencast from 09-22-2022 10:32:20 AM.webm](https://user-images.githubusercontent.com/1593513/191813642-ae0902da-5262-403a-bbdf-995334201acb.webm)
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 24, 2022
…r=GuillaumeGomez rustdoc: CSS prevent sidebar width change jank This commit makes the `width` and `min-width` of the sidebar the same. They originally were when cad0fce added the `min-width` rule, but 6a5f8b1 changed the `width` without changing the `min-width`, causing it to sometimes oscilate between 200 and 250 pixels depending on the main content. # Before [Screencast from 09-22-2022 10:25:29 AM.webm](https://user-images.githubusercontent.com/1593513/191813469-ea00f30f-6f49-40fc-9a26-e1dfd5068d2b.webm) # After [Screencast from 09-22-2022 10:32:20 AM.webm](https://user-images.githubusercontent.com/1593513/191813642-ae0902da-5262-403a-bbdf-995334201acb.webm)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#101780 (Add a platform support document for Android) - rust-lang#102044 (Remove `RtlGenRandom` (take two)) - rust-lang#102081 (Adding ignore fuchsia tests for execvp (pre_exec)) - rust-lang#102082 (Adding ignore fuchsia non-applicable commands) - rust-lang#102146 (rustdoc: CSS prevent sidebar width change jank) - rust-lang#102152 (Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly) - rust-lang#102175 (Also require other subtrees to always build successfully) - rust-lang#102176 (Add `llvm-dis` to the set of tools in `ci-llvm`) - rust-lang#102188 (Update doc after renaming `fn is_zero`) - rust-lang#102199 (Improve rustdoc GUI tests) - rust-lang#102218 (Document some missing command-line arguments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
widthandmin-widthof the sidebar the same. They originally were when cad0fce added themin-widthrule, but 6a5f8b1 changed thewidthwithout changing themin-width, causing it to sometimes oscilate between 200 and 250 pixels depending on the main content.Before
Screencast.from.09-22-2022.10.25.29.AM.webm
After
Screencast.from.09-22-2022.10.32.20.AM.webm