Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rustdoc GUI tests #102199

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Member

I finally finished the update so we can now store values in variables and use them. It improves things nicely.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 23, 2022
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 23, 2022

📌 Commit d30cb5b has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2022
…-tests, r=notriddle

Improve rustdoc GUI tests

I finally finished the update so we can now store values in variables and use them. It improves things nicely.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2022
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#101780 (Add a platform support document for Android)
 - rust-lang#102044 (Remove `RtlGenRandom` (take two))
 - rust-lang#102081 (Adding ignore fuchsia tests for execvp (pre_exec))
 - rust-lang#102082 (Adding ignore fuchsia non-applicable commands)
 - rust-lang#102146 (rustdoc: CSS prevent sidebar width change jank)
 - rust-lang#102152 (Calculate `ProjectionTy::trait_def_id` for return-position `impl Trait` in trait correctly)
 - rust-lang#102175 (Also require other subtrees to always build successfully)
 - rust-lang#102176 (Add `llvm-dis` to the set of tools in `ci-llvm`)
 - rust-lang#102188 (Update doc after renaming `fn is_zero`)
 - rust-lang#102199 (Improve rustdoc GUI tests)
 - rust-lang#102218 (Document some missing command-line arguments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 865e456 into rust-lang:master Sep 24, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 24, 2022
@GuillaumeGomez GuillaumeGomez deleted the improve-rustdoc-gui-tests branch September 24, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants