Add a detailed note for missing comma typo w/ FRU syntax #104504

compiler-errors · 2022-11-16T20:42:52Z

Thanks to @pierwill for working on this with me!

Fixes #104373, perhaps @alice-i-cecile can comment on the new error for the example provided on that issue -- feedback is welcome.

error[E0063]: missing field `defaulted` in initializer of `Outer`
  --> $DIR/multi-line-fru-suggestion.rs:14:5
   |
LL |     Outer {
   |     ^^^^^ missing `defaulted`
   |
note: this expression may have been misinterpreted as a `..` range expression
  --> $DIR/multi-line-fru-suggestion.rs:16:16
   |
LL |           inner: Inner {
   |  ________________^
LL | |             a: 1,
LL | |             b: 2,
LL | |         }
   | |_________^ this expression does not end in a comma...
LL |           ..Default::default()
   |           ^^^^^^^^^^^^^^^^^^^^ ... so this is interpreted as a `..` range expression, instead of functional record update syntax
help: to set the remaining fields from `Default::default()`, separate the last named field with a comma
   |
LL |         }, 
   |          +

error: aborting due to previous error

For more information about this error, try `rustc --explain E0063`.

rustbot · 2022-11-16T20:42:57Z

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2022-11-16T20:43:00Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

alice-i-cecile · 2022-11-16T20:49:20Z

compiler/rustc_error_messages/locales/en-US/hir_typeck.ftl

@@ -0,0 +1,8 @@
+hir_typeck_fru_note = this expression may have been misinterpreted as a `..` range expression
+hir_typeck_fru_expr = this expression does not end in a comma...
+hir_typeck_fru_expr2 = ... so this is interpreted as a `..` range expression, instead of functional record update syntax


"functional record update syntax" is pretty heavy on jargon (and this is an error beginners will regularly see). Google search for it turns up nothing unless you add Rust, in which case you get this RFC: https://rust-lang.github.io/rfcs/2528-type-changing-struct-update-syntax.html

Suggested change

hir_typeck_fru_expr2 = ... so this is interpreted as a `..` range expression, instead of functional record update syntax

hir_typeck_fru_expr2 = ... so this is interpreted as a `..` range expression, instead of functional record update syntax, used to set the remaining fields of a struct

This part of the error message is already pretty long, and it doesn't wrap well -- if you're against the jargon, I would rather remove everything after instead of.

I'm also not too keen on the duplication of "used to set the remaining fields of a struct" between the note and the suggestion's "to set the remaining fields"

Hmm, I see your point! I think it's better left as is then.

Maybe "struct update syntax"? I've heard that quite often when talking about FRU.

alice-i-cecile · 2022-11-16T20:57:19Z

compiler/rustc_hir_typeck/src/expr.rs

-                Applicability::MaybeIncorrect,
-            );
+                .ok()
+                .filter(|s| s.len() < 25 && !s.contains(|c: char| c.is_control()));


As someone new to this part of the codebase, this line is unclear to me. What's s, and why do we filter it like this? Why 25?

This is to avoid rendering very long expressions in "to set the remaining fields in $EXPR"

25 is an arbitrary number.

And is_control is to avoid rendering something like:

to set the remaining fields in `a .b`

Makes sense :) Perhaps leave a comment to this effect?

Sure thing.

estebank · 2022-11-17T18:11:40Z

r? @estebank
@bors r+

bors · 2022-11-17T18:11:42Z

📌 Commit b85b47cfd6c17acf21c8e3d6de3f543f3dbef942 has been approved by estebank

It is now in the queue for this repository.

compiler-errors · 2022-11-17T18:26:27Z

@bors r- i still got some changes to make

compiler-errors · 2022-11-18T18:09:40Z

@bors r=estebank

bors · 2022-11-18T18:09:42Z

📌 Commit bb0cb9a has been approved by estebank

It is now in the queue for this repository.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#101310 (Clarify and restrict when `{Arc,Rc}::get_unchecked_mut` is allowed.) - rust-lang#104461 (Fix building of `aarch64-pc-windows-gnullvm`) - rust-lang#104487 (update ntapi dep to remove future-incompat warning) - rust-lang#104504 (Add a detailed note for missing comma typo w/ FRU syntax) - rust-lang#104581 (rustdoc: remove unused JS IIFE from main.js) - rust-lang#104632 (avoid non-strict-provenance casts in libcore tests) - rust-lang#104634 (move core::arch into separate file) - rust-lang#104641 (replace unusual grammar) - rust-lang#104643 (add examples to chunks remainder methods. ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Nov 16, 2022

alice-i-cecile reviewed Nov 16, 2022

View reviewed changes

alice-i-cecile mentioned this pull request Nov 16, 2022

Formatting adds erroneous comma at end of struct update syntax when missing comma before .. rust-lang/rustfmt#5604

Open

rustbot assigned estebank and unassigned lcnr Nov 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2022

Add a detailed note for missing comma in FRU syntax typo

bb0cb9a

compiler-errors force-pushed the fru-syntax-note branch from b85b47c to bb0cb9a Compare November 18, 2022 17:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 18, 2022

matthiaskrgr mentioned this pull request Nov 20, 2022

Rollup of 9 pull requests #104655

Merged

bors merged commit fce077b into rust-lang:master Nov 21, 2022

rustbot added this to the 1.67.0 milestone Nov 21, 2022

compiler-errors deleted the fru-syntax-note branch August 11, 2023 20:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a detailed note for missing comma typo w/ FRU syntax #104504

Add a detailed note for missing comma typo w/ FRU syntax #104504

compiler-errors commented Nov 16, 2022

rustbot commented Nov 16, 2022

rustbot commented Nov 16, 2022

alice-i-cecile Nov 16, 2022

alice-i-cecile Nov 16, 2022

compiler-errors Nov 16, 2022

compiler-errors Nov 16, 2022 •

edited

Loading

alice-i-cecile Nov 16, 2022

Noratrieb Nov 17, 2022

alice-i-cecile Nov 16, 2022

compiler-errors Nov 16, 2022

compiler-errors Nov 16, 2022

compiler-errors Nov 16, 2022

alice-i-cecile Nov 16, 2022

compiler-errors Nov 16, 2022

estebank commented Nov 17, 2022

bors commented Nov 17, 2022

compiler-errors commented Nov 17, 2022

compiler-errors commented Nov 18, 2022

bors commented Nov 18, 2022

	hir_typeck_fru_expr2 = ... so this is interpreted as a `..` range expression, instead of functional record update syntax
	hir_typeck_fru_expr2 = ... so this is interpreted as a `..` range expression, instead of functional record update syntax, used to set the remaining fields of a struct

Add a detailed note for missing comma typo w/ FRU syntax #104504

Add a detailed note for missing comma typo w/ FRU syntax #104504

Conversation

compiler-errors commented Nov 16, 2022

rustbot commented Nov 16, 2022

rustbot commented Nov 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

compiler-errors Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estebank commented Nov 17, 2022

bors commented Nov 17, 2022

compiler-errors commented Nov 17, 2022

compiler-errors commented Nov 18, 2022

bors commented Nov 18, 2022

compiler-errors Nov 16, 2022 •

edited

Loading