Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace unusual grammar #104641

Merged
merged 1 commit into from
Nov 21, 2022
Merged

replace unusual grammar #104641

merged 1 commit into from
Nov 21, 2022

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@inquisitivecrystal inquisitivecrystal added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Nov 20, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 20, 2022

📌 Commit bebe5db has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2022
@bors
Auto merge of rust-lang#104655 - matthiaskrgr:rollup-r5kfffy, r=matth…
a102dc8 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101310 (Clarify and restrict when `{Arc,Rc}::get_unchecked_mut` is allowed.)
 - rust-lang#104461 (Fix building of `aarch64-pc-windows-gnullvm`)
 - rust-lang#104487 (update ntapi dep to remove future-incompat warning)
 - rust-lang#104504 (Add a detailed note for missing comma typo w/ FRU syntax)
 - rust-lang#104581 (rustdoc: remove unused JS IIFE from main.js)
 - rust-lang#104632 (avoid non-strict-provenance casts in libcore tests)
 - rust-lang#104634 (move core::arch into separate file)
 - rust-lang#104641 (replace unusual grammar)
 - rust-lang#104643 (add examples to chunks remainder methods. )

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9a95696 into rust-lang:master Nov 21, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 21, 2022
@tshepang tshepang deleted the grammar branch November 21, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @Mark-Simulacrum @bors @inquisitivecrystal