Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #47734

Closed
wants to merge 21 commits into from
Closed

Commits on Jan 20, 2018

  1. Configuration menu
    Copy the full SHA
    dbb6519 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. Do not suggest private traits that have missing method

    When encountering a method call for an ADT that doesn't have any
    implementation of it, we search for traits that could be implemented
    that do have that method. Filter out private non-local traits that would
    not be able to be implemented.
    
    This doesn't account for public traits that are in a private scope, but
    works as a first approximation and is a more correct behavior than the
    current one.
    estebank committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    4121ddb View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Remove broken redundant backtrace hint

    When the compiler driver panics it attempts to show a hint about using
    `RUST_BACKTRACE`. However, the logic is currently reversed to the hint
    is only shown if `RUST_BACKTRACE` is *already* set:
    
    ```shell
    > RUST_BACKTRACE=1 rustc /dev/null --crate-type proc-macro
    error: internal compiler error: unexpected panic
    ...
    note: run with `RUST_BACKTRACE=1` for a backtrace
    
    thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49
    note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    
    > RUST_BACKTRACE=0 rustc /dev/null --crate-type proc-macro
    error: internal compiler error: unexpected panic
    ...
    thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49
    note: Run with `RUST_BACKTRACE=1` for a backtrace.
    ```
    
    As the `panic` itself already has a working `RUST_BACKTRACE` hint just
    remove the broken duplicate hint entirely.
    etaoins committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    5de8e04 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06d123d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Configuration menu
    Copy the full SHA
    e6af9eb View commit details
    Browse the repository at this point in the history
  2. Remove workarounds for cc 1.0.3.

    Now that the Rust codebase depends on cc 1.0.4, there is no longer any
    need to specify a compiler for CloudABI manually. Cargo will
    automatically call into the right compiler executable.
    EdSchouten committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    583b382 View commit details
    Browse the repository at this point in the history
  3. Fix into() cast paren check precedence

    As discussed in rust-lang#47699 the logic for determining if an expression needs
    parenthesis when suggesting an `.into()` cast is incorrect. Two broken
    examples from nightly are:
    
    ```
    error[E0308]: mismatched types
     --> main.rs:4:10
      |
    4 |     test(foo as i8);
      |          ^^^^^^^^^ expected i32, found i8
    help: you can cast an `i8` to `i32`, which will sign-extend the source value
      |
    4 |     test(foo as i8.into());
      |
    ```
    
    ```
    error[E0308]: mismatched types
     --> main.rs:4:10
      |
    4 |     test(*foo);
      |          ^^^^ expected i32, found i8
    help: you can cast an `i8` to `i32`, which will sign-extend the source value
      |
    4 |     test(*foo.into());
      |
    ```
    
    As suggested by @petrochenkov switch the precedence check to
    PREC_POSTFIX. This catches both `as` and unary operators. Fixes rust-lang#47699.
    etaoins committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    65b1e86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05652d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1e991d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0847ac0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Update Cargo submodule to master

    Just a routine update
    alexcrichton committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    15899b0 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#47534 - estebank:suggest-public-traits, r=p…

    …etrochenkov
    
    On missing method do not suggest private traits
    
    When encountering a method call for an ADT that doesn't have any
    implementation of it, we search for traits that could be implemented
    that do have that method. Filter out private non-local traits that would
    not be able to be implemented.
    
    This doesn't account for public traits that are in a private scope, but
    works as a first approximation and is a more correct behavior than the
    current one.
    
    Fix rust-lang#45781.
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    147f5ce View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#47609 - ritiek:test-mutating-references, r=…

    …nikomatsakis
    
    NLL test for mutating &mut references
    
    As mentioned in rust-lang#46361.
    
    cc @nikomatsakis?
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    2afd21d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#47679 - etaoins:remove-redundant-backtrace-…

    …hint, r=estebank
    
    Remove broken redundant backtrace hint
    
    When the compiler driver panics it attempts to show a hint about using `RUST_BACKTRACE`. However, the logic is currently reversed to the hint is only shown if `RUST_BACKTRACE` is **already**   set:
    
    ```shell
    > RUST_BACKTRACE=1 rustc /dev/null --crate-type proc-macro
    error: internal compiler error: unexpected panic
    ...
    note: run with `RUST_BACKTRACE=1` for a backtrace
    
    thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49
    note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    
    > RUST_BACKTRACE=0 rustc /dev/null --crate-type proc-macro
    error: internal compiler error: unexpected panic
    ...
    thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49
    note: Run with `RUST_BACKTRACE=1` for a backtrace.
    ```
    
    As the `panic` itself already has a working `RUST_BACKTRACE` hint just remove the broken duplicate hint entirely.
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    0a1dcd3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#47691 - estebank:unknown-lang-item-sp, r=rk…

    …ruppe
    
    Point at unknown lang item attribute
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    7550753 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#47700 - EdSchouten:cc104, r=kennytm

    Remove workarounds for cc 1.0.3.
    
    Now that the Rust codebase depends on cc 1.0.4, there is no longer any
    need to specify a compiler for CloudABI manually. Cargo will
    automatically call into the right compiler executable.
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    47cb91a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#47702 - etaoins:fix-into-cast-paren-precede…

    …nce, r=petrochenkov
    
    Fix into() cast paren check precedence
    
    As discussed in rust-lang#47699 the logic for determining if an expression needs parenthesis when suggesting an `.into()` cast is incorrect. Two broken examples from nightly are:
    
    ```
    error[E0308]: mismatched types
     --> main.rs:4:10
      |
    4 |     test(foo as i8);
      |          ^^^^^^^^^ expected i32, found i8
    help: you can cast an `i8` to `i32`, which will sign-extend the source value
      |
    4 |     test(foo as i8.into());
      |
    ```
    
    ```
    error[E0308]: mismatched types
     --> main.rs:4:10
      |
    4 |     test(*foo);
      |          ^^^^ expected i32, found i8
    help: you can cast an `i8` to `i32`, which will sign-extend the source value
      |
    4 |     test(*foo.into());
      |
    ```
    
    As suggested by @petrochenkov switch the precedence check to `PREC_POSTFIX`. This catches both `as` and unary operators. Fixes rust-lang#47699.
    
    r? @petrochenkov
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    9d3d9d5 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#47717 - evelynmitchell:47716-doc-fix, r=ste…

    …veklabnik
    
    fix for documentation error issue 47716
    
    Fix rust-lang#47716
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f72d441 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#47721 - GuillaumeGomez:experimental-color, …

    …r=QuietMisdreavus
    
    Fix experimental text display on default theme
    
    r? @QuietMisdreavus
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    a4d31fc View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#47726 - pietroalbini:fix-nested-empty-group…

    …s-span, r=petrochenkov
    
    Fix spans in unused import lint for nested groups
    
    This fixes an inconsistency for empty nested groups, and adds a test for all the possible cases of the lint.
    
    ```
    warning: unused imports: `*`, `Foo`, `baz::{}`, `foobar::*`
      --> test.rs:16:11
       |
    16 | use foo::{Foo, bar::{baz::{}, foobar::*}, *};
       |           ^^^        ^^^^^^^  ^^^^^^^^^   ^
       |
       = note: #[warn(unused_imports)] on by default
    
    warning: unused import: `*`
      --> test.rs:17:24
       |
    17 | use foo::bar::baz::{*, *};
       |                        ^
    
    warning: unused import: `use foo::{};`
      --> test.rs:18:1
       |
    18 | use foo::{};
       | ^^^^^^^^^^^^
    ```
    
    cc rust-lang#44494
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    5d9ea4b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#47729 - alexcrichton:update-cargo, r=sfackler

    Update Cargo submodule to master
    
    Just a routine update
    GuillaumeGomez committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    e1fd7ca View commit details
    Browse the repository at this point in the history